Oct 2024

4 commits
Support configuring TLSv1.3 cipher suites
24 Oct 2024Daniel Gustafssonmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #302 of 4 reviewers saw the final version

The TLS cipher-suite patch in #30 matches the committed code and tests; only the documentation anchor and its cross-reference change from guc-ssl-cipher-suites to guc-ssl-tls13-ciphers in doc/src/sgml/config.sgml. The patch and commit credit Erica Zhang and sender Daniel Gustafsson as authors.

  • Jacob Championsaw the final versiontrailerJacob questioned compile-time defaults in #20, requested clearer naming in #22, accepted the revised name in #26, and gave final approval in #32.
  • Andres Freundno review foundtrailerAndres reviewed the curve-list feature in #14, but no review of the TLS cipher-suite feature is visible in this thread.
  • Peter Eisentrautsaw the final versiontrailerPeter supported a protocol-specific GUC name in #23 and said the series looked sensible in #29, after which this feature received only light changes.
  • Jelte Fennema-Niosaw an earlier versiontrailerJelte argued for separate cipher settings in #8, before subsequent revisions changed default handling and completed the implementation.
Support configuring multiple ECDH curves
24 Oct 2024Daniel Gustafssonmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #302 of 4 reviewers saw the final version

The complete seven-file group-list patch in #30 matches the commit after ignoring diff metadata and hunk offsets, including SSLerrmessageExt(), the GUC alias, documentation, and tests. Both the attachment and commit credit Erica Zhang alongside sender Daniel Gustafsson.

  • Jacob Championsaw the final versiontrailerJacob challenged manual parsing in #5, tested error handling in #19, refined the fallback and diagnostics through #28, and approved the final series in #32.
  • Andres Freundsaw an earlier versiontrailerAndres requested accurate naming, parsing rationale, better diagnostics, and documentation in #14, before custom validation was removed and error handling reworked.
  • Peter Eisentrautsaw the final versiontrailerPeter identified parsing semantics and Windows portability problems in #17 and later endorsed the series in #29, with only wording and documentation changes following for this feature.
  • Jelte Fennema-Niono review foundtrailerJelte's contributions in #8 and #9 concern cipher-suite configuration, with no identifiable review of the group-list implementation.
Raise the minimum supported OpenSSL version to 1.1.1
24 Oct 2024Daniel Gustafssonmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1Also in: Retire support for OpenSSL 1.1.1 due to raised API requirements (not this thread)
LLM analysis, 100% suremodified before commitlight changesfrom patchset #302 of 2 reviewers saw the final version

The prerequisite patch in #30 matches the committed API checks, LibreSSL documentation, and src/port/pg_strong_random.c cleanup, with only check ordering, build comments, a documentation parenthesis, and commit-message edits. This October 15 submission supersedes the September 9 source #571151 claimed by thread #50252, so that thread's attribution disagrees with the latest-matching-patchset rule.

  • Jacob Championsaw the final versionLLM analysis, 99% sureJacob reported failures with LibreSSL 3.3 and older in #22, assessed affected buildfarm systems in #26, and approved the final patch after identifying its missing parenthesis in #32.
  • Peter Eisentrautsaw the final versionLLM analysis, 91% surePeter endorsed the series and proposed removing the obsolete pre-1.1.1 randomness initialization in #29, which #30 implemented alongside documentation changes without altering supported-library behavior.
Handle alphanumeric characters in matching GUC names
24 Oct 2024Daniel Gustafssonmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #302 of 2 reviewers saw the final version

The one-line :alpha: to :alnum: replacement in src/test/modules/test_misc/t/003_check_guc.pl exactly matches the first patch of #30, which preserves the fix introduced in #25.

  • Peter Eisentrautsaw the final versionLLM analysis, 94% surePeter's general approval of the patches in #29 covers the four-patch series in #25, whose GUC-name fix remained unchanged.
  • Jacob Championsaw the final versionLLM analysis, 87% sureJacob gave the final series an LGTM in #32, with only an unrelated documentation-parenthesis correction requested.

Credits across 4 commits

Author
Daniel Gustafsson4
Erica Zhang2
Reviewer
Andres Freund2
Jacob Champion2
Jelte Fennema-Nio2
Peter Eisentraut2
Committer
Daniel Gustafsson4