Oct 2024

2 commits
Fix memory leaks from incorrect strsep() uses
18 Oct 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #162 of 2 reviewers saw the final version

The commit has the same stable patch ID as #16, preserving separate allocation pointers in src/common/logging.c and src/test/regress/pg_regress.c.

  • Alexander Lakhinsaw the final versionLLM analysis, 100% sureAlexander identified the lost allocation pointer in #14 and confirmed in #19 that #16 preserved color output while Ranier's alternative broke it.
  • Ranier Vilelasaw the final versionLLM analysis, 96% sureRanier reported testing Peter's fix on Windows in #20, observed missing color output with a possible platform explanation, and withdrew his alternative.
Fix strsep() use for SCRAM secrets parsing
18 Oct 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #121 of 2 reviewers saw the final version

The commit has the same stable patch ID as #12, replacing four strsep() return-value checks with checks of the advanced pointer in src/backend/libpq/auth-scram.c.

  • Alexander Lakhinsaw an earlier versionLLM analysis, 98% sureAlexander supplied a malformed SCRAM secret and crash backtrace in #10, exposing a bug in #1 before the subsequent parsing-logic correction.
  • Ranier Vilelasaw the final versionLLM analysis, 94% sureRanier diagnosed and tested the pointer-check correction in #11, then examined Peter's revision in #13, questioned removing redundant checks, and explicitly described his role as reviewer.

Jul 2024

4 commits
Windows replacement for strtok_r()
23 Jul 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #12 of 2 reviewers saw the final version

The commit's stable patch ID matches the Windows portability patch in #1, adding the strtok_r-to-strtok_s mapping in src/include/port/win32_port.h.

  • Kyotaro Horiguchisaw the final versiontrailerKyotaro examined the Windows mapping in #3 and noted that Cygwin already provided strtok_r(), while leaving its build implications unchecked.
  • David Steelesaw the final versiontrailerDavid's review of the rest of the series in #8 included the unchanged Windows portability patch.
Replace remaining strtok() with strtok_r()
23 Jul 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #12 of 2 reviewers saw the final version

The commit's stable patch ID matches the complete strtok_r() conversion patch in #1, including both tokenization sites in src/backend/utils/misc/tzparser.c.

  • Kyotaro Horiguchisaw the final versiontrailerKyotaro approved the tokenizer distinction and reported successful application and Linux tests in #3.
  • David Steelesaw the final versiontrailerDavid stated that he had reviewed the remaining patches and that they looked good in #8.
Replace some strtok() with strsep()
22 Jul 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #12 of 2 reviewers saw the final version

The commit's stable patch ID matches the strsep() conversion patch in #1 across auth-scram.c, pg_locale.c, logging.c, and pg_regress.c; differences in hunk locations reflect rebasing.

  • Kyotaro Horiguchisaw the final versiontrailerKyotaro agreed with the delimiter-semantics choices and reported passing Linux tests in #3.
  • David Steelesaw the final versiontrailerDavid endorsed strsep() as the natural abstraction and said the patch looked good in #8.
Add port/ replacement for strsep()
22 Jul 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #12 of 2 reviewers saw the final version

The commit's stable patch ID matches the complete strsep() portability patch in #1, including src/port/strsep.c and the configure, Meson, and header changes.

  • Kyotaro Horiguchisaw the final versiontrailerKyotaro said the replacement implementation looked fine and reported that it built and appeared to work with MSVC in #3.
  • David Steelesaw the final versiontrailerDavid accepted the supplied fallback as addressing compatibility and approved the series in #8.

Credits across 6 commits

Author
Peter EisentrautLLM6
Reviewer
David Steele4
Kyotaro Horiguchi4
Reported by
Alexander Lakhin2
Ranier Vilela1
Committer
Peter Eisentraut6

N LLM means N of the credits come from LLM analysis, not from commit trailers.