Jul 2024

1 commit
Use safe string copy routine
2 Jul 2024Daniel Gustafssonmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #262 of 5 reviewers saw the final version

The commit contains the same single replacement of memcpy with strlcpy in src/backend/access/transam/xlog.c as #26, with only the explicit (void) cast removed. Its author credit names Ranier Vilela, who sent that patchset, and Daniel Gustafsson confirms the push in #29.

  • Michael Paquiersaw the final versionLLM analysis, 95% sureMichael proposed strlcpy with sizeof in #3, defended that choice in #6, and endorsed preserving backward compatibility after the final revision in #28.
  • Richard Guosaw an earlier versionLLM analysis, 91% sureRichard checked both callers and challenged the original bug claim by identifying their zero-initialized BackupState allocations in #10, before the final replacement of memcpy with strlcpy.
  • Yugo Nagatasaw an earlier versionLLM analysis, 99% sureYugo identified the inconsistent length diagnostic in #11, rejected printing an oversized label in #14, and checked allocation lifetimes in #15, before the length-check and buffer-size changes were withdrawn.
  • Alvaro Herrerasaw an earlier versionLLM analysis, 98% sureAlvaro identified the truncation of previously valid 1024-character labels in #23, prompting the buffer-size and copy-bound corrections in #26.
  • Daniel Gustafssonsaw the final versioncommittercommitted the patch

Credits across 1 commit

Author
Ranier Vilela1
Reviewer
Daniel Gustafssoncommitter1
Committer
Daniel Gustafsson1