Doc: fix track_io_timing description to mention pg_stat_io
Hi,
pg_stat_io has I/O statistics that are collected when track_io_timing is
enabled, but it is not mentioned in the description of track_io_timing.
I think it's better to add a description of pg_stat_io for easy reference.
What do you think?
Regards,
--
Hajime Matsunaga
NTT DATA Group Corporation
Attachments:
guc-track-io-timing.patchapplication/octet-stream; name=guc-track-io-timing.patchDownload
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 0c7a9082c5..6718e325fc 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -8319,7 +8319,9 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
measure the overhead of timing on your system.
I/O timing information is
displayed in <link linkend="monitoring-pg-stat-database-view">
- <structname>pg_stat_database</structname></link>, in the output of
+ <structname>pg_stat_database</structname></link> and
+ <link linkend="monitoring-pg-stat-io-view">
+ <structname>pg_stat_io</structname></link>, in the output of
<xref linkend="sql-explain"/> when the <literal>BUFFERS</literal> option
is used, in the output of <xref linkend="sql-vacuum"/> when
the <literal>VERBOSE</literal> option is used, by autovacuum
On Thu, Jun 27, 2024 at 2:06 PM <Hajime.Matsunaga@nttdata.com> wrote:
Hi,
pg_stat_io has I/O statistics that are collected when track_io_timing is
enabled, but it is not mentioned in the description of track_io_timing.
I think it's better to add a description of pg_stat_io for easy reference.
What do you think?
Its always good to add new things.
Show quoted text
Regards,
--
Hajime Matsunaga
NTT DATA Group Corporation
Hi,
pg_stat_io has I/O statistics that are collected when track_io_timing is
enabled, but it is not mentioned in the description of track_io_timing.
I think it's better to add a description of pg_stat_io for easy reference.
What do you think?
Its always good to add new things.
Thanks for your positive comments.
Regards,
--
Hajime Matsunaga
NTT DATA Group Corporation
On Thu, Jun 27, 2024 at 5:06 AM <Hajime.Matsunaga@nttdata.com> wrote:
Hi,
pg_stat_io has I/O statistics that are collected when track_io_timing is
enabled, but it is not mentioned in the description of track_io_timing.
I think it's better to add a description of pg_stat_io for easy reference.
What do you think?
Seems quite reasonable to me given that track_wal_io_timing mentions
pg_stat_wal. I noticed that the sentence about track_io_timing in the
statistics collection configuration section [1]https://www.postgresql.org/docs/devel/monitoring-stats.html#MONITORING-STATS-SETUP only mentions reads
and writes -- perhaps it should also mention extends and fsyncs?
- Melanie
[1]: https://www.postgresql.org/docs/devel/monitoring-stats.html#MONITORING-STATS-SETUP
Hi,
On Thu, 27 Jun 2024 at 14:30, Melanie Plageman
<melanieplageman@gmail.com> wrote:
On Thu, Jun 27, 2024 at 5:06 AM <Hajime.Matsunaga@nttdata.com> wrote:
Hi,
pg_stat_io has I/O statistics that are collected when track_io_timing is
enabled, but it is not mentioned in the description of track_io_timing.
I think it's better to add a description of pg_stat_io for easy reference.
What do you think?Seems quite reasonable to me given that track_wal_io_timing mentions
pg_stat_wal. I noticed that the sentence about track_io_timing in the
statistics collection configuration section [1] only mentions reads
and writes -- perhaps it should also mention extends and fsyncs?
Both suggestions look good to me. If what you said will be
implemented, maybe track_wal_io_timing too should mention fsyncs?
--
Regards,
Nazir Bilal Yavuz
Microsoft
On Thu, Jun 27, 2024 at 5:06 AM <Hajime.Matsunaga@nttdata.com> wrote:
Hi,
pg_stat_io has I/O statistics that are collected when track_io_timing is
enabled, but it is not mentioned in the description of track_io_timing.
I think it's better to add a description of pg_stat_io for easy reference.
What do you think?Seems quite reasonable to me given that track_wal_io_timing mentions
pg_stat_wal. I noticed that the sentence about track_io_timing in the
statistics collection configuration section [1] only mentions reads
and writes -- perhaps it should also mention extends and fsyncs?Both suggestions look good to me. If what you said will be
implemented, maybe track_wal_io_timing too should mention fsyncs?
Thank you both for your positive comments.
I also think your suggestions seem good.
Regards,
--
Hajime Matsunaga
NTT DATA Group Corporation
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
Sent: Thursday, June 27, 2024 9:01 PM
Hi,
On Thu, 27 Jun 2024 at 14:30, Melanie Plageman
<melanieplageman@gmail.com> wrote:On Thu, Jun 27, 2024 at 5:06 AM <Hajime.Matsunaga@nttdata.com> wrote:
Hi,
pg_stat_io has I/O statistics that are collected when track_io_timing is
enabled, but it is not mentioned in the description of track_io_timing.
I think it's better to add a description of pg_stat_io for easy reference.
What do you think?Seems quite reasonable to me given that track_wal_io_timing mentions
pg_stat_wal. I noticed that the sentence about track_io_timing in the
statistics collection configuration section [1] only mentions reads
and writes -- perhaps it should also mention extends and fsyncs?Both suggestions look good to me. If what you said will be
implemented, maybe track_wal_io_timing too should mention fsyncs?
Thanks for the suggestions the other day.
I have created a patch that incorporates your suggestions.
Regards,
--
Hajime Matsunaga
NTT DATA Group Corporation
Attachments:
v2-0001-Doc-fix-track_io_timing-description-to-mention-pg.patchapplication/octet-stream; name=v2-0001-Doc-fix-track_io_timing-description-to-mention-pg.patchDownload
From 4bf5d5e5533b48eb302dec619592f9bff66d2f83 Mon Sep 17 00:00:00 2001
From: Hajime Matsunaga <hajime.matsunaga@oss.nttdata.com>
Date: Wed, 3 Jul 2024 07:22:29 +0000
Subject: [PATCH v2] Doc: fix track_io_timing description to mention pg_stat_io
---
doc/src/sgml/config.sgml | 4 +++-
doc/src/sgml/monitoring.sgml | 4 ++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 17d84bd321..ff7c1e7864 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -8319,7 +8319,9 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
measure the overhead of timing on your system.
I/O timing information is
displayed in <link linkend="monitoring-pg-stat-database-view">
- <structname>pg_stat_database</structname></link>, in the output of
+ <structname>pg_stat_database</structname></link> and
+ <link linkend="monitoring-pg-stat-io-view">
+ <structname>pg_stat_io</structname></link>, in the output of
<xref linkend="sql-explain"/> when the <literal>BUFFERS</literal> option
is used, in the output of <xref linkend="sql-vacuum"/> when
the <literal>VERBOSE</literal> option is used, by autovacuum
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 991f629907..ce133075a4 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -180,12 +180,12 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
<para>
The parameter <xref linkend="guc-track-io-timing"/> enables monitoring
- of block read and write times.
+ of block read, block write, extend, and fsync times.
</para>
<para>
The parameter <xref linkend="guc-track-wal-io-timing"/> enables monitoring
- of WAL write times.
+ of WAL write and fsync times.
</para>
<para>
--
2.43.0
On 2024/07/03 17:51, Hajime.Matsunaga@nttdata.com wrote:
Thanks for the suggestions the other day.
I have created a patch that incorporates your suggestions.
- <structname>pg_stat_database</structname></link>, in the output of
+ <structname>pg_stat_database</structname></link> and
+ <link linkend="monitoring-pg-stat-io-view">
+ <structname>pg_stat_io</structname></link>, in the output ofI'm not a native English speaker, but it seems more natural to use a comma instead of "and" before "pg_stat_io."
- of block read and write times.
+ of block read, block write, extend, and fsync times."block" before "fsync" doesn't seem necessary.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Sent: Wednesday, July 3, 2024 7:44 PM
On 2024/07/03 17:51, Hajime.Matsunaga@nttdata.com wrote:
Thanks for the suggestions the other day.
I have created a patch that incorporates your suggestions.- <structname>pg_stat_database</structname></link>, in the output of + <structname>pg_stat_database</structname></link> and + <link linkend="monitoring-pg-stat-io-view"> + <structname>pg_stat_io</structname></link>, in the output ofI'm not a native English speaker, but it seems more natural to use a comma instead of "and" before "pg_stat_io."
- of block read and write times. + of block read, block write, extend, and fsync times."block" before "fsync" doesn't seem necessary.
I'm also not a native English speaker, so I appreciate your feedback.
I have created a patch that incorporates your feedback.
Regards,
--
Hajime Matsunaga
NTT DATA Group Corporation
Attachments:
v3-0001-Doc-fix-track_io_timing-description-to-mention-pg.patchapplication/octet-stream; name=v3-0001-Doc-fix-track_io_timing-description-to-mention-pg.patchDownload
From ee09288d0b7c0fa5dfe6ffb7691f3f20b56ff03f Mon Sep 17 00:00:00 2001
From: Hajime Matsunaga <hajime.matsunaga@oss.nttdata.com>
Date: Mon, 8 Jul 2024 02:36:04 +0000
Subject: [PATCH v3] Doc: fix track_io_timing description to mention pg_stat_io
---
doc/src/sgml/config.sgml | 4 +++-
doc/src/sgml/monitoring.sgml | 4 ++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index f627a3e63c..4a0c9ba97d 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -8319,7 +8319,9 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
measure the overhead of timing on your system.
I/O timing information is
displayed in <link linkend="monitoring-pg-stat-database-view">
- <structname>pg_stat_database</structname></link>, in the output of
+ <structname>pg_stat_database</structname></link>,
+ <link linkend="monitoring-pg-stat-io-view">
+ <structname>pg_stat_io</structname></link>, in the output of
<xref linkend="sql-explain"/> when the <literal>BUFFERS</literal> option
is used, in the output of <xref linkend="sql-vacuum"/> when
the <literal>VERBOSE</literal> option is used, by autovacuum
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 991f629907..9ca74348c7 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -180,12 +180,12 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser
<para>
The parameter <xref linkend="guc-track-io-timing"/> enables monitoring
- of block read and write times.
+ of block read, write, extend, and fsync times.
</para>
<para>
The parameter <xref linkend="guc-track-wal-io-timing"/> enables monitoring
- of WAL write times.
+ of WAL write and fsync times.
</para>
<para>
--
2.43.0
On 2024/07/08 12:01, Hajime.Matsunaga@nttdata.com wrote:
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Sent: Wednesday, July 3, 2024 7:44 PMOn 2024/07/03 17:51, Hajime.Matsunaga@nttdata.com wrote:
Thanks for the suggestions the other day.
I have created a patch that incorporates your suggestions.- <structname>pg_stat_database</structname></link>, in the output of + <structname>pg_stat_database</structname></link> and + <link linkend="monitoring-pg-stat-io-view"> + <structname>pg_stat_io</structname></link>, in the output ofI'm not a native English speaker, but it seems more natural to use a comma instead of "and" before "pg_stat_io."
- of block read and write times. + of block read, block write, extend, and fsync times."block" before "fsync" doesn't seem necessary.
I'm also not a native English speaker, so I appreciate your feedback.
I have created a patch that incorporates your feedback.
Thanks for updating the patch! Pushed.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION