stale comments about fastgetattr and heap_getattr

Started by Junwang Zhaoover 1 year ago3 messages
#1Junwang Zhao
zhjwpku@gmail.com
1 attachment(s)

fastgetattr and heap_getattr are converted to inline functions
in e27f4ee0a701, while some comments still referring them as macros.

--
Regards
Junwang Zhao

Attachments:

0001-stale-comments-about-fastgetattr-and-heap_getattr.patchapplication/octet-stream; name=0001-stale-comments-about-fastgetattr-and-heap_getattr.patchDownload
From e4281f197d92061bc2544c62223b95bcca5d6e6d Mon Sep 17 00:00:00 2001
From: Zhao Junwang <zhjwpku@gmail.com>
Date: Fri, 28 Jun 2024 02:51:19 +0000
Subject: [PATCH] stale comments about fastgetattr and heap_getattr

fastgetattr and heap_getattr are converted to inline functions
in e27f4ee0a701, while some comments still referring them as macros.

Signed-off-by: Zhao Junwang <zhjwpku@gmail.com>
---
 src/backend/access/common/heaptuple.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/backend/access/common/heaptuple.c b/src/backend/access/common/heaptuple.c
index 5c89fbbef8..153fbcd3ff 100644
--- a/src/backend/access/common/heaptuple.c
+++ b/src/backend/access/common/heaptuple.c
@@ -495,7 +495,7 @@ heap_attisnull(HeapTuple tup, int attnum, TupleDesc tupleDesc)
 /* ----------------
  *		nocachegetattr
  *
- *		This only gets called from fastgetattr() macro, in cases where
+ *		This only gets called from fastgetattr(), in cases where
  *		we can't use a cacheoffset and the value is not null.
  *
  *		This caches attribute offsets in the attribute descriptor.
@@ -715,7 +715,7 @@ nocachegetattr(HeapTuple tup,
  *
  *		Fetch the value of a system attribute for a tuple.
  *
- * This is a support routine for the heap_getattr macro.  The macro
+ * This is a support routine for heap_getattr().  The function
  * has already determined that the attnum refers to a system attribute.
  * ----------------
  */
-- 
2.41.0

#2Stepan Neretin
sncfmgg@gmail.com
In reply to: Junwang Zhao (#1)
Re: stale comments about fastgetattr and heap_getattr

Hi! Looks good to me. Please, register it in CF.
Best regards, Stepan Neretin.

On Fri, Jun 28, 2024 at 10:05 AM Junwang Zhao <zhjwpku@gmail.com> wrote:

Show quoted text

fastgetattr and heap_getattr are converted to inline functions
in e27f4ee0a701, while some comments still referring them as macros.

--
Regards
Junwang Zhao

#3Michael Paquier
michael@paquier.xyz
In reply to: Stepan Neretin (#2)
Re: stale comments about fastgetattr and heap_getattr

On Fri, Jun 28, 2024 at 11:06:05AM +0700, Stepan Neretin wrote:

Hi! Looks good to me. Please, register it in CF.
Best regards, Stepan Neretin.

No need for that. I've looked at the patch, and you are right so I
have applied it now on HEAD.
--
Michael