Oct 2024

5 commits
Don't hard-code the input file name in gen_tabcomplete.pl's output.
10 Oct 2024Tom Lanemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #141 of 1 reviewer saw the final version

c75c6f8d28 implements all six #line replacements from #14, using a named $infile variable instead of direct $ARGV[0] references. It also incorporates that message's inline src/bin/psql/meson.build correction.

  • Tom Lanesaw the final versioncommittercommitted the patch
Avoid possible segfault in psql's tab completion.
10 Oct 2024Tom Lanemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #112 of 2 reviewers saw the final version

95eb4cd4ff takes the exact previous_words_count > 0 guard from #11 in src/bin/psql/tab-complete.in.c. The five-line addition to src/bin/psql/t/010_tab_completion.pl is omitted.

  • Daniel Gustafssonsaw the final versionLLM analysis, 100% sureDaniel independently encountered the crash, developed the same guard, and explicitly endorsed the patch after reading the code in #12; only the proposed test was omitted.
  • Tom Lanesaw the final versioncommittercommitted the patch
Convert tab-complete's long else-if chain to a switch statement.
7 Oct 2024Tom Lanemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 98% surepart of a posted patchsetlight changesfrom patchset #61 of 2 reviewers saw the final version

f391d9dc93 takes the third member of #6, adding gen_tabcomplete.pl, build rules, and the source-file rename. After ignoring rebase metadata, its only edit to that member changes the comment wording from 'shorn of' to 'minus'.

  • Andres Freundsaw an earlier versionLLM analysis, 100% sureAndres tested #2, reported compilation improvements and successful MSVC operation, and identified editor diagnostics and an unwanted install rule in #3, prompting the subsequent preprocessor redesign.
  • Thomas Munrosaw the final versionLLM analysis, 100% sureThomas reported successful testing and endorsed the mechanism in #7, also requesting simpler comment wording that was adopted before commit.
Prepare tab-complete.c for preprocessing.
7 Oct 2024Tom Lanemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 98% surepart of a posted patchsetlight changesfrom patchset #61 of 2 reviewers saw the final version

bd1276a3c9 takes the complete second member of #6, extracting match_previous_words() and adding conditional table-driven infrastructure plus the TCPattern typedef entry. Its diff matches that member after excluding rebase metadata and hunk positions.

  • Andres Freundsaw an earlier versionLLM analysis, 99% sureAndres tested the original extraction and conversion series in #3, before #5 reorganized the preparation code to support both preprocessed and unprocessed execution.
  • Thomas Munrosaw the final versionLLM analysis, 100% sureThomas reported that the revised series worked as expected and that its mechanism was reasonable in #7, with no subsequent substantive change to this member.
Invent "MatchAnyN" option for tab-complete.c's Matches/MatchesCS.
7 Oct 2024Tom Lanemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 98% surepart of a posted patchsetlight changesfrom patchset #62 of 2 reviewers saw the final version

ef0938f7bd takes the complete first member of #6, introducing MatchAnyN and array-based matching helpers in src/bin/psql/tab-complete.c. Its diff matches that member after excluding rebase metadata and hunk positions.

  • Andres Freundsaw the final versionLLM analysis, 99% sureAndres tested the original series in #3, and its MatchAnyN member remained substantively unchanged through #6 and commit.
  • Thomas Munrosaw the final versionLLM analysis, 100% sureThomas tested and endorsed the revised series in #7, covering the MatchAnyN implementation committed without substantive changes.

Credits across 5 commits

Author
Tom LaneLLM3
Anthonin BonnefoyLLM1
Jacob ChampionLLM1
Reviewer
Tom Lanecommitter2
Committer
Tom Lane5

N LLM means N of the credits come from LLM analysis, not from commit trailers.