model-writtenrun 3155 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Tatsuo Ishii reported executor and replication-origin warnings when compiling without -fno-strict-aliasing, attached a temporary-pointer workaround for the executor, and asked whether the replication-origin cast should also be fixed #1.
- Tom Lane objected that the attached workaround suppressed warnings without explaining or resolving the underlying aliasing issue, and suggested investigating whether IsA itself could be improved #2.
- Peter Eisentraut proposed replacing the replication-origin CRC cast with memcpy #3, and Tom Lane endorsed that fix while requesting that the block follow the read-error check #4.
- For the executor warnings, Peter suggested directly inspecting error_occurred or allocating ErrorSaveContext separately #5 #7; Tom disliked bypassing the abstraction but supported the pointer-member approach #6 #9.
- Tom's GCC 11 experiment found another warning involving TOAST_COMPRESS_METHOD in verify_heapam.c, although check-world passed; he considered a union workaround cumbersome #8.
- Tatsuo disputed the need to change ErrorSaveContext storage, arguing that an intermediate pointer alone silenced the warning, and supplied a standalone reproducer without revising the patch #10 #11.
- After a long gap, Peter committed the inline replication-origin fix, including Tom's error-check ordering suggestion, as 2fcc5a7151 and announced it in #12; the attached executor workaround was not included.
- Peter's renewed investigation suggested embedding Node members or using may_alias annotations for broader fixes, but he deferred that work and concluded that -fno-strict-aliasing remained necessary #12.
- Andres Freund subsequently challenged Peter's interpretation of C's aggregate aliasing rules #13, and Peter explained why he thought the cited aggregate-access provision did not justify the needed casts #14; the thread ended with the replication-origin fix landed and the broader aliasing questions unresolved.