Remove dead code generation tools in src/backend/utils/mb/

Heikki Linnakangas <hlinnaka@iki.fi> writes:

These programs in src/backend/utils/mb/ are unused, and have been unused
and unusable since 2003:
iso.c
win1251.c
win866.c
Attached patch removes them. See commit message for a little more
detailed analysis.

+1. Seems to have been my oversight in 4c3c8c048d.

regards, tom lane

Hello Tom and Heikki,

29.07.2024 17:15, Tom Lane wrote:

Heikki Linnakangas <hlinnaka@iki.fi> writes:

These programs in src/backend/utils/mb/ are unused, and have been unused
and unusable since 2003:
iso.c
win1251.c
win866.c
Attached patch removes them. See commit message for a little more
detailed analysis.

+1. Seems to have been my oversight in 4c3c8c048d.

I also wonder whether src/test/locale/ still makes sense; does anyone
run those tests (I could not run a single one on a quick attempt)?

(As far as I can tell, KOI8-R fallen out of mainstream usage in Russia
twenty years ago...)

Best regards,
Alexander

On 7/29/24 5:00 PM, Alexander Lakhin wrote:

I also wonder whether src/test/locale/ still makes sense; does anyone
run those tests (I could not run a single one on a quick attempt)?

I was actually wondering about those yesterday and they should probably
be removed (or fixed if anyone can see a use for them). As they are
right now they do not seem very useful, especially with the current
selection of locales: de_DE.ISO8859-1, gr_GR.ISO8859-7 and koi8-r.

Andreas

On 29/07/2024 17:15, Tom Lane wrote:

Heikki Linnakangas <hlinnaka@iki.fi> writes:

These programs in src/backend/utils/mb/ are unused, and have been unused
and unusable since 2003:
iso.c
win1251.c
win866.c
Attached patch removes them. See commit message for a little more
detailed analysis.

+1. Seems to have been my oversight in 4c3c8c048d.

Removed.

(Aleksander, you forgot to CC the mailing list, but thanks for your
review too.)

--
Heikki Linnakangas
Neon (https://neon.tech)