Comment in portal.h

Started by Etsuro Fujitaover 1 year ago3 messages

etsuro.fujita@gmail.com

over 1 year ago

1 attachment(s)

Hi,

I noticed $SUBJECT while working on something else:

/*
* Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING or
* PORTAL_UTIL_SELECT query. (A cursor held past the end of its
* transaction no longer has any active executor state.)
*/
Tuplestorestate *holdStore; /* store for holdable cursors */
MemoryContext holdContext; /* memory containing holdStore */

We do that for PORTAL_ONE_MOD_WITH as well, so the comment should be
"Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING,
PORTAL_ONE_MOD_WITH, or PORTAL_UTIL_SELECT query.". Attached is a
patch for that.

Best regards,
Etsuro Fujita

Attachments:

update-comment.patchapplication/octet-stream; name=update-comment.patchDownload

diff --git a/src/include/utils/portal.h b/src/include/utils/portal.h
index 11419faeca..29f49829f2 100644
--- a/src/include/utils/portal.h
+++ b/src/include/utils/portal.h
@@ -170,9 +170,9 @@ typedef struct PortalData
 	Snapshot	portalSnapshot; /* active snapshot, or NULL if none */
 
 	/*
-	 * Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING or
-	 * PORTAL_UTIL_SELECT query.  (A cursor held past the end of its
-	 * transaction no longer has any active executor state.)
+	 * Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING,
+	 * PORTAL_ONE_MOD_WITH, or PORTAL_UTIL_SELECT query.  (A cursor held past
+	 * the end of its transaction no longer has any active executor state.)
 	 */
 	Tuplestorestate *holdStore; /* store for holdable cursors */
 	MemoryContext holdContext;	/* memory containing holdStore */

Andy Fan

zhihuifan1213@163.com

over 1 year ago

In reply to: Etsuro Fujita (#1)

Re: Comment in portal.h

Etsuro Fujita <etsuro.fujita@gmail.com> writes:

Hi,

I noticed $SUBJECT while working on something else:

/*
* Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING or
* PORTAL_UTIL_SELECT query. (A cursor held past the end of its
* transaction no longer has any active executor state.)
*/
Tuplestorestate *holdStore; /* store for holdable cursors */
MemoryContext holdContext; /* memory containing holdStore */

We do that for PORTAL_ONE_MOD_WITH as well, so the comment should be
"Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING,
PORTAL_ONE_MOD_WITH, or PORTAL_UTIL_SELECT query.". Attached is a
patch for that.

Patch looks good to me.

All the codes of PortalRun & FillPortalStore & PortalRunSelect are
consistent with this idea.

--
Best Regards
Andy Fan

Etsuro Fujita

etsuro.fujita@gmail.com

over 1 year ago

In reply to: Andy Fan (#2)

Re: Comment in portal.h

Hi,

On Wed, Jul 31, 2024 at 8:55 AM Andy Fan <zhihuifan1213@163.com> wrote:

Etsuro Fujita <etsuro.fujita@gmail.com> writes:

I noticed $SUBJECT while working on something else:

/*
* Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING or
* PORTAL_UTIL_SELECT query. (A cursor held past the end of its
* transaction no longer has any active executor state.)
*/
Tuplestorestate *holdStore; /* store for holdable cursors */
MemoryContext holdContext; /* memory containing holdStore */

We do that for PORTAL_ONE_MOD_WITH as well, so the comment should be
"Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING,
PORTAL_ONE_MOD_WITH, or PORTAL_UTIL_SELECT query.". Attached is a
patch for that.

Patch looks good to me.

All the codes of PortalRun & FillPortalStore & PortalRunSelect are
consistent with this idea.

Pushed. Thanks for looking!

Best regards,
Etsuro Fujita