Jul - Aug 2024

10 commits
Use psprintf to simplify gtsvectorout()
6 Aug 2024Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #41 of 1 reviewer saw the final version

The diff matches the gtsvectorout() patch in #4, replacing cached buffer sizing and sprintf() with psprintf() and pstrdup() in src/backend/utils/adt/tsgistidx.c.

  • Andres Freundsaw the final versiontrailerAndres approved this cleanup in #5, observing that the undocumented EXTRALEN was especially confusing.
Constify fields and parameters in spell.c
6 Aug 2024Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #41 of 1 reviewer saw the final version

The diff matches the spell.c patch in #4, adding const qualifiers to VoidString and related fields, parameters, and local pointers in src/backend/tsearch/spell.c and src/include/tsearch/dicts/spell.h.

  • Andres Freundsaw the final versiontrailerAndres reviewed the spell changes in #5 and said they looked reasonable.
Mark misc static global variables as const
6 Aug 2024Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #41 of 1 reviewer saw the final version

All five declaration changes match the miscellaneous const patch in #4, including the local const HASHCTL in src/backend/access/transam/xlogprefetcher.c.

  • Andres Freundsaw the final versiontrailerAndres gave the miscellaneous const changes an LGTM in #5.
Make nullSemAction const, add 'const' decorators to related functions
6 Aug 2024Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #41 of 1 reviewer saw the final version

The diff matches the nullSemAction patch in #4, propagating const JsonSemAction pointers through src/common/jsonapi.c, JSON wrappers, headers, and the incremental parser test.

  • Andres Freundsaw the final versiontrailerAndres approved the JSON const changes in #5 and noted that they also reduce writable mappings.
Turn a few 'validnsps' static variables into locals
6 Aug 2024Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #41 of 1 reviewer saw the final version

Compared with #4, the sole diff change adds the missing pointer-level const to validnsps in src/backend/tcop/utility.c. Andres identified the inconsistency in #5, and Heikki confirmed fixing it before pushing in #6.

  • Andres Freundsaw the final versiontrailerAndres identified the missing const qualifier and discussed static versus local initialization in #5; only the requested light correction followed.
Refactor getWeights to write to caller-supplied buffer
30 Jul 2024Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The diff matches the getWeights() patch in #1, introducing caller-supplied weight buffers and direct use of default_weights in src/backend/utils/adt/tsrank.c.

  • Robert Haassaw the final versiontrailerRobert reported looking through the series in #2 and considered all five patches good cleanups without a plausible objection.
Replace static buf with a stack-allocated one in 'seg' extension
30 Jul 2024Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The code diff matches the seg patch in #1, replacing the initialized static buffer with a local buffer and using snprintf() in contrib/seg/segparse.y.

  • Robert Haassaw the final versiontrailerRobert reviewed the initial series in #2 and endorsed its five cleanups, including the seg buffer change.
Replace static buf with a stack-allocated one in ReadControlFile
30 Jul 2024Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The diff matches the ReadControlFile() patch in #1, making wal_segsz_str a stack buffer in src/backend/access/transam/xlog.c.

  • Robert Haassaw the final versiontrailerRobert reviewed and endorsed the initial five-patch series in #2, including the ReadControlFile() cleanup.
Replace static buf with palloc in str_time()
30 Jul 2024Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The code diff matches the str_time() patch in #1, allocating 128 bytes with palloc() and passing that size to pg_strftime() in src/backend/access/transam/xlog.c.

  • Robert Haassaw the final versiontrailerRobert reviewed and endorsed the initial five-patch series in #2, including the str_time() allocation change.
Replace static bufs with a StringInfo in cash_words()
30 Jul 2024Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The code diff matches the cash_words() patch in #1, replacing fixed buffers and string concatenation with StringInfo and append_num_word() in src/backend/utils/adt/cash.c.

  • Robert Haassaw the final versiontrailerRobert reviewed and endorsed the initial five-patch series in #2, including the cash_words() refactoring.

Credits across 10 commits

Author
Heikki LinnakangasLLM10
Reviewer
Andres Freund5
Robert Haas5
Committer
Heikki Linnakangas10

N LLM means N of the credits come from LLM analysis, not from commit trailers.