Remove obsolete RECHECK keyword completely

Started by Peter Eisentrautover 1 year ago4 messageshackers
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

I propose to remove the obsolete RECHECK keyword completely. This used
to be part of CREATE OPERATOR CLASS and ALTER OPERATOR FAMILY, but it
has done nothing (except issue a NOTICE) since PostgreSQL 8.4. Commit
30e7c175b81 removed support for dumping from pre-9.2 servers, so this no
longer serves any need, it seems to me.

This now removes it completely, and you'd get a normal parse error if
you used it.

Attachments:

0001-Remove-obsolete-RECHECK-keyword-completely.patchtext/plain; charset=UTF-8; name=0001-Remove-obsolete-RECHECK-keyword-completely.patchDownload+4-42
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#1)
Re: Remove obsolete RECHECK keyword completely

Peter Eisentraut <peter@eisentraut.org> writes:

I propose to remove the obsolete RECHECK keyword completely. This used
to be part of CREATE OPERATOR CLASS and ALTER OPERATOR FAMILY, but it
has done nothing (except issue a NOTICE) since PostgreSQL 8.4. Commit
30e7c175b81 removed support for dumping from pre-9.2 servers, so this no
longer serves any need, it seems to me.

+1 for the idea; didn't vet the patch closely.

regards, tom lane

#3Aleksander Alekseev
aleksander@timescale.com
In reply to: Peter Eisentraut (#1)
Re: Remove obsolete RECHECK keyword completely

Hi,

I propose to remove the obsolete RECHECK keyword completely. This used
to be part of CREATE OPERATOR CLASS and ALTER OPERATOR FAMILY, but it
has done nothing (except issue a NOTICE) since PostgreSQL 8.4. Commit
30e7c175b81 removed support for dumping from pre-9.2 servers, so this no
longer serves any need, it seems to me.

This now removes it completely, and you'd get a normal parse error if
you used it.

I reviewed and tested the code. LGTM.

--
Best regards,
Aleksander Alekseev

#4Peter Eisentraut
peter_e@gmx.net
In reply to: Aleksander Alekseev (#3)
Re: Remove obsolete RECHECK keyword completely

On 05.08.24 15:44, Aleksander Alekseev wrote:

I propose to remove the obsolete RECHECK keyword completely. This used
to be part of CREATE OPERATOR CLASS and ALTER OPERATOR FAMILY, but it
has done nothing (except issue a NOTICE) since PostgreSQL 8.4. Commit
30e7c175b81 removed support for dumping from pre-9.2 servers, so this no
longer serves any need, it seems to me.

This now removes it completely, and you'd get a normal parse error if
you used it.

I reviewed and tested the code. LGTM.

committed, thanks