Remove TRACE_SORT macro?

Started by Peter Eisentrautover 1 year ago3 messageshackers
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

I think we could remove the TRACE_SORT macro.

The TRACE_SORT macro has guarded the availability of the trace_sort GUC
setting. But it has been enabled by default ever since it was
introduced in PostgreSQL 8.1, and there have been no reports that
someone wanted to disable it. So I think we could just remove the macro
to simplify things.

Attachments:

0001-Remove-TRACE_SORT-macro.patchtext/plain; charset=UTF-8; name=0001-Remove-TRACE_SORT-macro.patchDownload+0-96
#2Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Peter Eisentraut (#1)
Re: Remove TRACE_SORT macro?

On 07/08/2024 09:56, Peter Eisentraut wrote:

I think we could remove the TRACE_SORT macro.

The TRACE_SORT macro has guarded the availability of the trace_sort GUC
setting.  But it has been enabled by default ever since it was
introduced in PostgreSQL 8.1, and there have been no reports that
someone wanted to disable it.  So I think we could just remove the macro
to simplify things.

+1, I don't see why anyone would want to build without TRACE_SORT.

--
Heikki Linnakangas
Neon (https://neon.tech)

#3Peter Eisentraut
peter_e@gmx.net
In reply to: Heikki Linnakangas (#2)
Re: Remove TRACE_SORT macro?

On 07.08.24 09:24, Heikki Linnakangas wrote:

On 07/08/2024 09:56, Peter Eisentraut wrote:

I think we could remove the TRACE_SORT macro.

The TRACE_SORT macro has guarded the availability of the trace_sort GUC
setting.  But it has been enabled by default ever since it was
introduced in PostgreSQL 8.1, and there have been no reports that
someone wanted to disable it.  So I think we could just remove the
macro to simplify things.

+1, I don't see why anyone would want to build without TRACE_SORT.

committed