Dec 2024

1 commit
Fix temporary memory leak in system table index scans
3 Dec 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The commit adds pfree(idxkey) in both system-table scan functions in src/backend/access/index/genam.c, following the memory accumulation report #8 and successful test of explicit frees #10. Neither attached patchset contains these frees; Peter confirms committing the fix in #11.

  • Justin Pryzbysaw the final versionLLM analysis, 100% sureJustin reported the memory accumulation in #8 and confirmed that corresponding pfree calls fixed it in #10, before the commit.

Sep 2024

2 commits
Don't overwrite scan key in systable_beginscan()
12 Sep 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #60 of 3 reviewers saw the final version

The changed lines exactly match the scan-key-copying and caller-cleanup patches from #6, combined across genam.c, catcache.c, and relfilenumbermap.c, modulo rebased context. Peter explicitly selected these for folding together in #7, leaving the const API changes and stack-allocation alternative out.

  • Robert Haassaw an earlier versionLLM analysis, 96% sureRobert identified the additional palloc overhead in #2, before the caller-side logic cleanup added in #6.
  • Tom Lanesaw an earlier versionLLM analysis, 98% sureTom assessed allocation overhead in #3 and requested removal of redundant copying in #5, which led to caller-side logic changes in #6.
  • Noah Mischsaw an earlier versionLLM analysis, 99% sureNoah identified obsolete caller assumptions and comments in #4, prompting the additional catcache.c and relfilenumbermap.c cleanup in #6.
Replace gratuitous memmove() with memcpy()
11 Sep 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #6

This commits only the memcpy cleanup component of #6: all added and removed lines match that attachment across seven index-access-method files. Differences are rebased context, including function signatures without the uncommitted const qualifiers.

Credits across 3 commits

Author
Peter EisentrautLLM2
Reported by
Justin Pryzby1
Committer
Peter Eisentraut3

N LLM means N of the credits come from LLM analysis, not from commit trailers.