Aug 2024

1 commit
libpq: Fix minor TOCTOU violation
16 Aug 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #12 of 2 reviewers saw the final version

The commit preserves both functional hunks from #1 in src/interfaces/libpq/fe-connect.c and adds an #ifndef WIN32 guard around the stat_buf declaration. This is a small portability cleanup accompanying the removal of stat() on Windows.

  • Aleksander Alekseevsaw the final versiontrailerAleksander supported the simple fix for the static-analyzer warning in #2, and only a light declaration guard was added before committing.
  • Andreas Karlssonsaw the final versiontrailerAndreas endorsed the correctness improvement, noted the unnecessary Windows stat() call, and recommended committing in #3; only a light declaration guard followed.

Credits across 1 commit

Author
Peter EisentrautLLM1
Reviewer
Aleksander Alekseev1
Andreas Karlsson1
Committer
Peter Eisentraut1

N LLM means N of the credits come from LLM analysis, not from commit trailers.