model-writtenrun 3017 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Stepan Neretin proposed changing SPI_connect and SPI_connect_ext to return void and removing result checks because these functions could only return SPI_OK_CONNECT #1.
- Tom Lane rejected breaking the SPI API and external extensions for little benefit #3; Stepan accepted that objection and asked whether checks should instead be added consistently #4.
- David G. Johnston proposed deprecating the return value #5, Tom suggested documenting that failures use elog/ereport #6, and David pointed out that the existing SPI example already omitted the check #7.
- Stepan submitted a documentation-only alternative that removed SPI_ERROR_CONNECT from the documented results but added a check to the SPI example #8; Peter Eisentraut then supported preserving the API while moving errors to exceptions and linked earlier discussion #9.
- Tom combined portions of both patches into a replacement that preserved the API, documented the return value as historical, and removed checks throughout core, contrib, and the trigger example #10; he argued that SPI_connect's behavior since PostgreSQL 10 justified this cleanup, while other SPI functions would require a longer transition.
- Stepan endorsed the replacement #11, and Tom announced his intention to commit it #12; it landed unchanged as 218527d014, with completion confirmed in #13.
- Robert Haas offered support after the commit #14; the agreed cleanup was complete, while the void-return proposal and the alternative of adding example checks had been superseded.