Mar 2025

3 commits
Fix "‘static’ is not at beginning of declaration" warning
29 Mar 2025Andres Freundmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Andres reports the compiler warning and promises the fix in #18; no attachment contains it. The commit changes only "const static" to "static const" in src/port/pg_localeconv_r.c.

Use thread-safe strftime_l() instead of strftime().
28 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #151 of 2 reviewers saw the final version

Extracts the strftime component and its error-reporting fixup from #15, leaving the other series components separate. Applying those two attachments to the commit parent reproduces all four committed source files exactly.

  • Heikki Linnakangassaw an earlier versiontrailerHis request in #2 to revise the global-locale warning prompted the LC_TIME extension in #6, but the thread shows no direct review of the subsequently added strftime implementation.
  • Peter Eisentrautsaw the final versiontrailerPeter reviewed the strftime patch in #13, supplied the shared error-reporting fixup in #15, and reviewed the final version as committer.
Provide thread-safe pg_localeconv_r().
27 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #151 of 2 reviewers saw the final version

Extracts the localeconv component and cosmetic fixup from #15. Beyond those attachments, src/port/pg_localeconv_r.c corrects HAVE_LOCALE_CONV_L to HAVE_LOCALECONV_L and replaces a goto to a nonexistent label with conditional copying, matching the BSD-branch issue reported in #16.

  • Heikki Linnakangassaw an earlier versiontrailerHeikki reviewed the initial localeconv implementation in #2, requesting clearer platform logic and preservation of encoding commentary before the category-copying and Windows save/restore revisions.
  • Peter Eisentrautsaw the final versiontrailerPeter approved the rebased localeconv approach and supplied cosmetic fixes in #15, then corrected the BSD branch and committed it as reported in #16.

Aug 2024

4 commits
Harmonize MinGW CODESET lookup with MSVC.
14 Aug 2024Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #5

The src/port/chklocale.c diff matches #5 exactly: MinGW uses the MSVC lookup path and win32_langinfo() becomes win32_get_codeset().

Include <xlocale.h> for macOS, take II.
13 Aug 2024Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Thomas diagnoses the macOS header-guard typo in #4, following the build failures in #3. With no matching attachment, the commit changes LOCALE_T_IN_XLOCALE_H to LOCALE_T_IN_XLOCALE in src/port/chklocale.c.

Use thread-safe nl_langinfo_l(), not nl_langinfo().
13 Aug 2024Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #11 of 1 reviewer saw the final version

Lands only the nl_langinfo_l() component of #1; its src/port/chklocale.c changes match apart from whitespace. The header-probe cleanup and localeconv implementation are separate components.

  • Heikki Linnakangassaw the final versiontrailerHeikki explicitly approved the first two patches in #2 and corrected the locale typo and POSIX version wording.
All POSIX systems have langinfo.h and CODESET.
13 Aug 2024Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #11 of 1 reviewer saw the final version

Lands the langinfo-probe cleanup component of #1, additionally removing an obsolete HAVE_LANGINFO_H-guarded include from src/bin/pg_upgrade/pg_upgrade.c. The other two series components are excluded.

  • Heikki Linnakangassaw the final versiontrailerHeikki explicitly approved this component in #2, after which only the additional obsolete include cleanup was made.

Credits across 7 commits

Author
Thomas Munro3 LLM5
Reviewer
Heikki Linnakangas4
Peter Eisentraut2
Committer
Thomas Munro4
Peter Eisentraut2
Andres Freund1

N LLM means N of the credits come from LLM analysis, not from commit trailers.