Mar - Apr 2025

9 commits
Relax ordering-related hardcoded btree requirements in planning
6 Apr 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #460 of 1 reviewer saw the final version

This lands the remaining ordering, merge-join and predicate reasoning portion of #46. It factors built-in-AM shortcuts into get_opmethod_canorder() and reworks translation in mergejoinscansel(), while other portions landed separately.

  • Alexandra Wangsaw an earlier versionLLM analysis, 78% sureShe tested the original archived API-cleanup series with the cloned index modules and check-world in #6, before substantial restructuring of this planner work.
Support non-btree indexes in get_actual_variable_range()
4 Apr 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #460 of 1 reviewer saw the final version

The get_actual_variable_range() and get_actual_variable_endpoint() hunks in src/backend/utils/adt/selfuncs.c match the corresponding subset of #46, including abandoning scans that require recheck.

  • Alexandra Wangsaw an earlier versionLLM analysis, 75% sureHer regression testing of the original archived series in #6 covered the index-generalization work before the later revisions and extraction of this change.
Convert PathKey to use CompareType
4 Apr 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #460 of 1 reviewer saw the final version

This extracts the PathKey and MergeScanSelCache conversions from #46, with matching postgres_fdw and plan-construction changes. Translation bridges preserve interfaces whose broader conversion was deferred to the subsequent planner commit.

  • Alexandra Wangsaw an earlier versionLLM analysis, 77% sureShe reported regression and check-world results for the original archived series in #6, before the PathKey interface was substantially simplified.
Generalize index support in network support function
25 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #440 of 1 reviewer saw the final version

All changed lines in src/backend/utils/adt/network.c match the complete network-support patch attached in #44.

  • Alexandra Wangsaw an earlier versionLLM analysis, 75% sureShe tested the earlier archived series in #6, while #44 explains that the network changes subsequently required functional corrections.
Update a code comment
19 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 95% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The trailer links this comment cleanup to the thread and credits Mark Dilger, but no indexed patch contains its src/backend/parser/parse_utilcmd.c hunk. It removes the obsolete uniqueness rationale while retaining the btree restriction for upgrade compatibility.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Allow non-btree unique indexes for matviews
18 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #381 of 1 reviewer saw the final version

The complete materialized-view patch in #38 matches the committed src/backend/commands/matview.c changes, including COMPARE_EQ lookup and removal of the btree-only check.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Allow non-btree unique indexes for partition keys
18 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #381 of 1 reviewer saw the final version

This matches the partition-key patch in #38, but moves the missing-equality-operator error outside the unique-index branch and replaces Assert(idx_eqop). The change answers the concern in #40 and is confirmed in #43.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Add some opfamily support functions to lsyscache.c
18 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #381 of 2 reviewers saw the final version

This combines the first two patches of #38, adding get_opfamily_method() and get_opfamily_member_for_cmptype(). The latter now requests missing_ok and returns InvalidOid when translation fails, as discussed in #39 and confirmed in #42.

  • Tom Lanesaw an earlier versionLLM analysis, 98% sureHe identified the unexpected translation error in #39, prompting the subsequent behavioral change to return InvalidOid.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Simplify and generalize PrepareSortSupportFromIndexRel()
14 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #370 of 1 reviewer saw the final version

All changed lines match #37: PrepareSortSupportFromIndexRel() receives a boolean, its callers supply sort direction, and the access-method check uses amcanorder.

  • Alexandra Wangsaw an earlier versionLLM analysis, 76% sureShe tested the original archived generalization in #6, before Peter replaced its strategy-translation approach with the boolean interface in #37.

Feb 2025

9 commits
Generalize hash and ordering support in amapi
27 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #351 of 2 reviewers saw the final version

This matches the hash-and-ordering capability patch in #35, with documentation added to doc/src/sgml/indexam.sgml and revised comments in amapi.h and opclasscmds.c.

  • Alexandra Wangsaw an earlier versionLLM analysis, 97% sureShe tested the capability changes and diagnosed the missing xtree amcancrosscompare flag in #13, before the later main-series revisions.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Drop opcintype from index AM strategy translation API
21 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #34

The commit combines both patches in #34; their normalized changed lines match the commit, apart from the added catalog-version bump in src/include/catalog/catversion.h.

Allow non-btree speculative insertion indexes
7 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #330 of 1 reviewer saw the final version

The complete speculative-insertion patch in #33 matches src/backend/catalog/index.c, removing the btree restriction and obtaining each equality strategy through IndexAmTranslateCompareType().

  • Alexandra Wangsaw an earlier versionLLM analysis, 83% sureHer full-series testing in #6 covered the original speculative-insertion work, before the revised translation-based implementation in #33.
Support non-btree indexes for foreign keys
7 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #330 of 1 reviewer saw the final version

All changed lines match the foreign-key patch in #33, replacing the btree-only branch in tablecmds.c with generalized equality/overlap strategy translation.

  • Alexandra Wangsaw an earlier versionLLM analysis, 83% sureShe tested the original archived foreign-key generalization as part of the full series in #6, before Peter reworked its capability checks in #33.
Integrate GistTranslateCompareType() into IndexAmTranslateCompareType()
3 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #300 of 2 reviewers saw the final version

This matches the GiST integration patch in #30, except GetOperatorFromCompareType() obtains the AM through get_opclass_method(opclass) instead of hardcoding GIST_AM_OID. The adjustment resolves #31 as explained in #32.

  • Paul A Jungwirthsaw an earlier versionLLM analysis, 81% sureHe assessed the earlier GiST CompareType and logical-replication direction in #26, before the callbacks and callers were integrated in #30.
  • Alexandra Wangsaw an earlier versionLLM analysis, 76% sureShe tested the original archived API-cleanup series in #6, before the GiST-specific integration and replica-identity rework.
Convert strategies to and from compare types
2 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #301 of 1 reviewer saw the final version

The callback implementation matches its patch in #30; the commit additionally introduces COMPARE_INVALID here, moving that declaration out of the preceding header-extraction patch.

  • Peter Eisentrautsaw the final versiontrailerHe split and renamed the original translation work in #30 and reviewed the final implementation as its committer.
Move CompareType to separate header file
2 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #301 of 1 reviewer saw the final version

This matches the cmptype.h extraction in #30, updating the copyright year and postponing COMPARE_INVALID to the following callback commit.

  • Peter Eisentrautsaw the final versiontrailerHe extracted this header change from Mark's larger patch in #30 and committed its adjusted final form.
Add get_opfamily_name() function
1 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #301 of 1 reviewer saw the final version

This combines the get_opfamily_name() helper and its callers from #30; the combined normalized changed lines match exactly, while the other four patches landed separately.

  • Mark Dilgersaw the final versiontrailerHe explicitly endorsed the preparatory refactorings and their reduction of duplication in #31.
Rename GistTranslateStratnum() to GistTranslateCompareType()
1 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #301 of 1 reviewer saw the final version

All changed lines match the complete GistTranslateStratnum-to-GistTranslateCompareType rename patch in #30.

  • Mark Dilgersaw the final versiontrailerHe said the preparatory renaming and refactoring patches looked sensible and raised no objection in #31.

Jan 2025

2 commits
Change gist stratnum function to use CompareType
15 Jan 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #251 of 1 reviewer saw the final version

This matches the GiST CompareType patch in #25, with one additional caller conversion in src/backend/executor/execReplication.c to replace RTEqualStrategyNumber with COMPARE_EQ.

  • Paul A Jungwirthsaw the final versionLLM analysis, 93% sureHe examined the CompareType mapping against temporal-key and logical-replication requirements and reported no replication problems with it in #26.
Rename RowCompareType to CompareType
15 Jan 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #251 of 1 reviewer saw the final version

The complete RowCompareType-to-CompareType rename in #25 matches the committed changed lines across the executor, parser, planner and headers.

  • Mark Dilgersaw the final versiontrailerHe explicitly endorsed the proposed rename in #24, before the indexed attachment, and the commit credits that review.

Nov 2024

1 commit
Improve slightly misleading internal error message
27 Nov 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 98% surewritten from the discussion, no matching patch

No indexed patch contains this nbtutils.c error-message correction. Its trailer connects it to the discussion distinguishing strategy numbers from RowCompareType in #18 and #23.

Oct 2024

2 commits
Track scan reversals in MergeJoin
14 Oct 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surewritten from the discussion, no matching patch1 of 2 reviewers saw the final version

Peter explicitly reviewed this archived main-series patch in #15 and announced its landing in #17. The mergeStrategies-to-mergeReversals change has no matching indexed attachment, so no valid source patchset ID is available.

  • Alexandra Wangsaw an earlier versionLLM analysis, 86% sureShe tested the original archived series containing this MergeJoin change in #6, with no indexed patchset available for that reviewed version.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Track sort direction in SortGroupClause
14 Oct 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surewritten from the discussion, no matching patch1 of 2 reviewers saw the final version

The SortGroupClause reverse_sort addition is identified as an archived main-series patch in Peter's review #15, followed by the commit announcement #17. None of the indexed attachments contains that patch.

  • Alexandra Wangsaw an earlier versionLLM analysis, 86% sureShe tested the original archived series containing the sort-direction change in #6, before the later main-series revisions.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Sep 2024

1 commit
Add amgettreeheight index AM API routine
10 Sep 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #111 of 2 reviewers saw the final version

The commit matches #11, adding only initialization of the amroutine local to NULL in plancat.c. Peter explains this compiler-warning fix in #14.

  • Alexandra Wangsaw an earlier versionLLM analysis, 86% sureShe tested the original archived series in #6, before Peter changed the callback wrapper and removed the unnecessary IndexOptInfo addition in #11.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Credits across 24 commits

Author
Mark Dilger15
Peter EisentrautLLM5
Reviewer
Peter Eisentrautcommitter10
Mark Dilger3
Co author
Peter Eisentraut5
Mark Dilger3
Committer
Peter Eisentraut24

N LLM means N of the credits come from LLM analysis, not from commit trailers.