JIT: Remove some unnecessary instructions.

Started by Xing Guoabout 2 years ago6 messageshackers
Jump to latest
#1Xing Guo
higuoxing@gmail.com

Hi hackers,

I find there are some unnecessary load/store instructions being
emitted by the JIT compiler.

E.g.,

```
v_boolnull = l_load(b, TypeStorageBool, v_resnullp, "");
v_boolvalue = l_load(b, TypeSizeT, v_resvaluep, "");

/* set resnull to boolnull */
LLVMBuildStore(b, v_boolnull, v_resnullp);
/* set revalue to boolvalue */
LLVMBuildStore(b, v_boolvalue, v_resvaluep);
```

v_boolnull is loaded from v_resnullp and stored to v_resnullp immediately.
v_boolvalue is loaded from v_resvaluep and stored to v_resvaluep immediately.

The attached patch is trying to fix them.

Best Regards,
Xing

Attachments:

0001-JIT-Remove-some-unnecessary-instructions.patchtext/x-patch; charset=US-ASCII; name=0001-JIT-Remove-some-unnecessary-instructions.patchDownload+1-15
#2Andreas Karlsson
andreas.karlsson@percona.com
In reply to: Xing Guo (#1)
Re: JIT: Remove some unnecessary instructions.

On 8/30/24 5:55 AM, Xing Guo wrote:

I find there are some unnecessary load/store instructions being
emitted by the JIT compiler.

Well spotted! All of these are obvious dead instructions and while LLVM
might be able to optimize them away there is no reason to create extra
work for the optimizer.

The patch looks good, applies and the tests passes.

Andreas

#3Xing Guo
higuoxing@gmail.com
In reply to: Andreas Karlsson (#2)
Re: JIT: Remove some unnecessary instructions.

On Fri, Aug 30, 2024 at 8:50 PM Andreas Karlsson <andreas@proxel.se> wrote:

On 8/30/24 5:55 AM, Xing Guo wrote:

I find there are some unnecessary load/store instructions being
emitted by the JIT compiler.

Well spotted! All of these are obvious dead instructions and while LLVM
might be able to optimize them away there is no reason to create extra
work for the optimizer.

The patch looks good, applies and the tests passes.

Thanks for testing it! I spotted another unnecessary store instruction
and added it in my V2 patch.

Best Regards,
Xing

Attachments:

v2-0001-JIT-Remove-unnecessary-load-store-instructions.patchtext/x-patch; charset=US-ASCII; name=v2-0001-JIT-Remove-unnecessary-load-store-instructions.patchDownload+1-16
#4Andreas Karlsson
andreas.karlsson@percona.com
In reply to: Xing Guo (#3)
Re: JIT: Remove some unnecessary instructions.

On 9/2/24 4:23 AM, Xing Guo wrote:

Thanks for testing it! I spotted another unnecessary store instruction
and added it in my V2 patch.

Another well-spotted unnecessary store. Nice!

I think this patch is ready for committer. It is simple and pretty
obviously correct.

Andreas

#5Andreas Karlsson
andreas.karlsson@percona.com
In reply to: Andreas Karlsson (#4)
Re: JIT: Remove some unnecessary instructions.

On 9/2/24 9:06 PM, Andreas Karlsson wrote:

On 9/2/24 4:23 AM, Xing Guo wrote:

Thanks for testing it! I spotted another unnecessary store instruction
and added it in my V2 patch.

Another well-spotted unnecessary store. Nice!

I think this patch is ready for committer. It is simple and pretty
obviously correct.

Oh, and please add your patch to the commitfest app so it is not lost.

https://commitfest.postgresql.org/50/

Andreas

#6Heikki Linnakangas
hlinnaka@iki.fi
In reply to: Andreas Karlsson (#4)
Re: JIT: Remove some unnecessary instructions.

On 02/09/2024 22:06, Andreas Karlsson wrote:

On 9/2/24 4:23 AM, Xing Guo wrote:

Thanks for testing it! I spotted another unnecessary store instruction
and added it in my V2 patch.

Another well-spotted unnecessary store. Nice!

I think this patch is ready for committer. It is simple and pretty
obviously correct.

Committed, thanks!

--
Heikki Linnakangas
Neon (https://neon.tech)