May 2025

1 commit
Ensure we have a snapshot when updating various system catalogs.
30 May 2025Nathan Bossartmaster18beta2REL_19_STABLE18beta2REL_18_STABLE18beta2REL_17_STABLE17.6REL_16_STABLE16.10REL_15_STABLE15.14REL_14_STABLE14.19REL_13_STABLE13.22Also in: BUG #18127: Assertion HaveRegisteredOrActiveSnapshot failed on REINDEX CONCURRENTLY when blocksize=1 (written from the discussion, no matching patch)Also in: BUG #18309: TOASTed entry in pg_subscription provokes an assertion failure
LLM analysis, 94% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The commit adds snapshots around index swapping in src/backend/commands/indexcmds.c and deletion in src/backend/postmaster/autovacuum.c, corresponding to the final branch-specific staging in #60, review in #61, and commitment in #62, whose attachments have no indexed patchset. I disagree with attributing implementation provenance to thread #72125: its verdict explicitly excludes its diagnostic attachment as the source, whereas this thread contains the later implementation and commitment round; thread #72342 has no patchsets.

  • Michael Paquiersaw the final versiontrailerReviewed the broader snapshot work in #18, #22, and #26, then reviewed the final staged versions and older-branch replication-origin exception in #61, whose referenced attachments have no indexed patchset entry.

May 2025

1 commit
Remove pg_replication_origin's TOAST table.
7 May 2025Nathan Bossartmaster18beta2REL_19_STABLE18beta2REL_18_STABLE18beta2
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #521 of 5 reviewers saw the final version

Retains the TOAST removal, documentation, tests, and invariant assertion from #52, but moves the length check back into replorigin_create() following #55 and #57. It also revises comments and bumps catversion.

  • Michael Paquiersaw the final versiontrailerReviewed #52 in #55 and requested the final placement of the length check in replorigin_create(), reiterating that recommendation in #57.
  • Amit Kapilasaw an earlier versiontrailerProposed replacing replication-origin snapshot protection with TOAST removal and a bounded name in #33 and #35, before the removal patch was posted.
  • Euler Taveirasaw an earlier versiontrailerApproved #39 with documentation and cosmetic suggestions in #40, before subsequent validation-placement changes and the no-TOAST assertion.
  • Nisha Moondsaw an earlier versiontrailerTested #42 and proposed moving validation to the SQL function in #43, a change adopted temporarily but reversed before commitment.
  • Tom Lanesaw an earlier versiontrailerRequested explanatory comments and the no-TOAST assertion in #46 and #49, then approved with a comment nit in #51, before validation moved back to the internal API.

Sep 2024

2 commits
Ensure we have a snapshot when updating pg_index entries.
26 Sep 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #151 of 1 reviewer saw the final version

Matches the snapshot placement and regression tests in #15, with small comment edits and replacement of ActiveSnapshotSet() by HaveRegisteredOrActiveSnapshot() in the nonconcurrent-path assertion.

  • Michael Paquiersaw the final versiontrailerRequested comments in #10, reviewed snapshot placement in #16, and reported successful regression testing of the reindex changes in #18.
Add TOAST table to pg_index.
18 Sep 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #21 of 1 reviewer saw the final version

Preserves the TOAST declaration and expected-result changes from #2, adding a catversion bump and updating the exception comments in misc_sanity.sql and its expected output. The optional checks in #7 were posted after commitment and are absent.

  • Tom Lanesaw the final versiontrailerAssessed the circularity risk in #3 and explicitly raised no objection to commitment in #6.

Credits across 4 commits

Author
Nathan BossartLLM3
Reviewer
Michael Paquier3
Tom Lane2
Amit Kapila1
Euler Taveira1
Nisha Moond1
Reported by
Alexander Lakhin2
Jonathan S. Katz1
Committer
Nathan Bossart4

N LLM means N of the credits come from LLM analysis, not from commit trailers.