Nov 2024

2 commits
Use pg_memory_is_all_zeros() in PageIsVerifiedExtended()
18 Nov 2024Michael Paquiermaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #893 of 3 reviewers saw the final version

The commit takes only the second patch of #89: its src/backend/storage/page/bufpage.c diff matches exactly, replacing the size_t loop with pg_memory_is_all_zeros(pagebytes, BLCKSZ). The helper optimization landed separately.

  • David Rowleysaw the final versionLLM analysis, 89% sureDavid identified the original page-check defects in #22, benchmarked and accepted the replacement approach in #40, and reviewed #63, whose bufpage.c changes match the final page patch.
  • Ranier Vilelasaw the final versionLLM analysis, 93% sureRanier reported benchmarks including the 8192-byte page case in #81 and #93 and explicitly said the final series #89 looked good.
  • Michael Paquiersaw the final versioncommittercommitted the patch
Optimize pg_memory_is_all_zeros() in memutils.h
18 Nov 2024Michael Paquiermaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #892 of 2 reviewers saw the final version

Takes the first patch of #89, preserving all executable changes in src/include/utils/memutils.h while adjusting comment wording and interval notation. Although the attachment retains Michael Paquier's From header, the commit explicitly credits sender Bertrand Drouvot as author and David Rowley for the optimization suggestions.

  • Michael Paquiersaw the final versiontrailerMichael benchmarked the implementations, requested the size_t remainder and medium-buffer paths, supplied portable comments in #88, and committed after additional checks reported in #96.
  • Ranier Vilelasaw the final versiontrailerRanier benchmarked successive implementations, questioned the 32-bit comments in #84 and #86, and explicitly approved the final series in #93.

Nov 2024

2 commits
Remove use of pg_memory_is_all_zeros() in bufpage.c
1 Nov 2024Michael Paquiermaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #292 of 2 reviewers saw the final version

The src/backend/storage/page/bufpage.c diff exactly matches #29, restoring the original size_t loop and removing the faulty helper call.

  • David Rowleysaw the final versionLLM analysis, 95% sureDavid reported the incorrect length in #22, demonstrated the slowdown in #26, and requested the exact rollback in #27 instead of the length-only repair he assessed in #28.
  • Bertrand Drouvotsaw the final versionLLM analysis, 98% sureBertrand independently reported the slowdown and proposed reverting in #24, then accepted the attached rollback with only a documentation suggestion in #30.
Add pg_memory_is_all_zeros() in memutils.h
1 Nov 2024Michael Paquiermaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #204 of 4 reviewers saw the final version

All executable changes match #20 across the three statistics callers, bufpage.c, and memutils.h. The committer only quotes the parameter names and wraps the helper's introductory comment, apart from rebase context.

  • Peter Eisentrautsaw the final versiontrailerPeter challenged the struct-padding assumptions in #4, requested a void pointer in #12, and restored const qualification through #16, after which only light refinements followed.
  • Heikki Linnakangassaw the final versiontrailerHeikki proposed the byte-scanning implementation in #6 and identified the invalid benchmark underlying #11 in #13, with his scanning algorithm retained through the landing.
  • Peter Smithsaw the final versiontrailerPeter supplied comparison benchmarks in #10 and corrected the helper's parameter documentation in #18, which was incorporated into #20.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Credits across 4 commits

Author
Bertrand Drouvot3
Michael PaquierLLM1
Reviewer
Michael Paquiercommitter3
Heikki Linnakangas1
Peter Eisentraut1
Peter Smith1
Ranier Vilela1
Committer
Michael Paquier4

N LLM means N of the credits come from LLM analysis, not from commit trailers.