Patch: Make pg_waldump.sgml less confusing
The pg_waldump manpage says the --save-fullpage output format was
TIMELINE-LSN.RELTABLESPACE.DATOID.RELNODE.BLKNOFORK
when the filenames actually have the format
00000001-00000000-309A88C0.1663.5.64080.0_main
with an underscore in front of FORK.
While that is technically correct because it then explains that
FORK is something like "_main", I think this is just confusing and
moving the underscore into the file name format description is much
cleaner. (And inside the rest of the code, the fork names don't have
underscore prefixes either.)
Christoph
Attachments:
0001-pg_waldump.sgml-Put-underscore-in-front-of-FORK.patchtext/x-diff; charset=us-asciiDownload+3-4
On Tue, Oct 01, 2024 at 11:44:40PM +0200, Christoph Berg wrote:
While that is technically correct because it then explains that
FORK is something like "_main", I think this is just confusing and
moving the underscore into the file name format description is much
cleaner. (And inside the rest of the code, the fork names don't have
underscore prefixes either.)
Good point. What you are proposing is easier to read. Will fix.
Thanks for the report.
--
Michael