Mar 2025

3 commits
psql: Fix incorrect equality comparison
27 Mar 2025Daniel Gustafssonmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetsignificant changesfrom patchset #311 of 1 reviewer saw the final version

The commit exactly takes the src/bin/psql/variables.c hunk from #31, changing errno = ERANGE to errno == ERANGE. It omits all changes to the attachment's other 28 files; the significant difference is scope reduction, with no rewrite of the retained fix.

  • Daniel Gustafssonsaw the final versioncommittercommitted the patch
psql: Make test robust against locale variations
26 Mar 2025Daniel Gustafssonmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Matches Daniel Gustafsson's inline diff in #27, replacing 0.001 with 10 in both the WATCH_INTERVAL test input and expected output in src/bin/psql/t/001_basic.pl. No attached patchset contains this test correction.

  • Pavel Stehulesaw the final versiontrailerReported and isolated the Czech-locale failure in #25 and #26, then confirmed that the inline fix from #27 passed in #28.
psql: Make default \watch interval configurable
25 Mar 2025Daniel Gustafssonmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surelanded as postedfrom patchset #223 of 7 reviewers saw the final version

The eight-file diff matches #22 apart from line wrapping of an unchanged comment in src/bin/psql/command.c. The commit message additionally records that this is the first command with a user-configurable default, as promised in #22.

  • Heikki Linnakangassaw an earlier versiontrailerFound the compilation failure, inaccurate minimum diagnostic, and typos in #2, before the later ERANGE and maximum-bound logic was added.
  • Michael Paquiersaw an earlier versiontrailerQuestioned fractional-second support and optional units in #4, then withdrew the concern in #7, before later parser changes.
  • Kirill Reshkesaw an earlier versiontrailerRequested ERANGE diagnostics and suggested a maximum argument in #8, with those parser changes introduced after his review.
  • Masahiro Ikedasaw an earlier versiontrailerTested and reviewed #9, reporting the missing math.h include and proposing parser, documentation, and help improvements in #10, before maximum-bound handling was added.
  • Laurenz Albesaw the final versiontrailerReported successful testing and approved the code in #13; after the temporary endpoint restriction was reversed, the committed executable logic matched his reviewed version, with only comments, documentation, and tests differing.
  • Greg Sabino Mullanesaw the final versiontrailerReviewed the bound behavior in #14 and #16, then reviewed the restored zero support in #20 and requested diagnostic wording that remained unchanged at landing.
  • Ashutosh Bapatsaw the final versiontrailerRequested consistent zero support and execution testing in #18, refined documentation in #21, and explicitly approved the final attachment in #23.

Credits across 3 commits

Author
Daniel Gustafsson2
Ranier VilelaLLM1
Reviewer
Ashutosh Bapat1
Daniel Gustafssoncommitter1
Greg Sabino Mullane1
Heikki Linnakangas1
Kirill Reshke1
Laurenz Albe1
Masahiro Ikeda1
Michael Paquier1
Pavel Stehule1
Reported by
Pavel Stehule1
Ranier Vilela1
Committer
Daniel Gustafsson3

N LLM means N of the credits come from LLM analysis, not from commit trailers.