Remove obsolete comment in reorderbuffer.h

Started by Masahiko Sawadaover 1 year ago3 messages
#1Masahiko Sawada
sawada.mshk@gmail.com
1 attachment(s)

Hi,

I realized an obsolete comment in the definition of ReorderBufferTXN.

Commit 9fab40ad32e changed ReorderBuffer to use Slab Context for
allocating ReorderBufferTXN entries instead of using a caching
mechanism, so the txn->node is no longer used as an element of the
list of preallocated ReorderBufferTXNs.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Attachments:

v1-0001-Remove-obsolete-comment-in-reorderbuffer.h.patchapplication/octet-stream; name=v1-0001-Remove-obsolete-comment-in-reorderbuffer.h.patchDownload
From ab4f232856ef38558d984bb1cc80db2fcc1f2c52 Mon Sep 17 00:00:00 2001
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Fri, 11 Oct 2024 16:59:52 -0700
Subject: [PATCH v1] Remove obsolete comment in reorderbuffer.h.

Commit 9fab40ad32e changed ReorderBuffer to use Slab Context for
allocating ReorderBufferTXN entries instead of using a caching
mechanism. The txn->node is no longer used as an element of the list
of preallocated ReorderBufferTXNs.

Reviewed-by:
Discussion: https://postgr.es/m/
---
 src/include/replication/reorderbuffer.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/include/replication/reorderbuffer.h b/src/include/replication/reorderbuffer.h
index e332635f70..6ad5a8cb9c 100644
--- a/src/include/replication/reorderbuffer.h
+++ b/src/include/replication/reorderbuffer.h
@@ -394,10 +394,9 @@ typedef struct ReorderBufferTXN
 	SharedInvalidationMessage *invalidations;
 
 	/* ---
-	 * Position in one of three lists:
+	 * Position in one of two lists:
 	 * * list of subtransactions if we are *known* to be subxact
 	 * * list of toplevel xacts (can be an as-yet unknown subxact)
-	 * * list of preallocated ReorderBufferTXNs (if unused)
 	 * ---
 	 */
 	dlist_node	node;
-- 
2.39.3

#2Amit Kapila
amit.kapila16@gmail.com
In reply to: Masahiko Sawada (#1)
Re: Remove obsolete comment in reorderbuffer.h

On Sat, Oct 12, 2024 at 5:42 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:

I realized an obsolete comment in the definition of ReorderBufferTXN.

Commit 9fab40ad32e changed ReorderBuffer to use Slab Context for
allocating ReorderBufferTXN entries instead of using a caching
mechanism, so the txn->node is no longer used as an element of the
list of preallocated ReorderBufferTXNs.

I agree, and your patch looks good to me.

--
With Regards,
Amit Kapila.

#3Masahiko Sawada
sawada.mshk@gmail.com
In reply to: Amit Kapila (#2)
Re: Remove obsolete comment in reorderbuffer.h

On Sun, Oct 13, 2024 at 8:57 PM Amit Kapila <amit.kapila16@gmail.com> wrote:

On Sat, Oct 12, 2024 at 5:42 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:

I realized an obsolete comment in the definition of ReorderBufferTXN.

Commit 9fab40ad32e changed ReorderBuffer to use Slab Context for
allocating ReorderBufferTXN entries instead of using a caching
mechanism, so the txn->node is no longer used as an element of the
list of preallocated ReorderBufferTXNs.

I agree, and your patch looks good to me.

Thank you for reviewing the patch. Pushed.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com