Aug 2025

2 commits
Put back intra-grant-inplace.spec test coverage
27 Aug 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1REL_18_STABLE18rc1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #91 of 1 reviewer saw the final version

The diff exactly matches the second patch of #9, changing intra-grant-inplace.spec and its expected output to exercise catalog-row disappearance through DELETE FROM pg_class; the accompanying comment patch landed separately.

  • Heikki Linnakangassaw the final versiontrailerIn #12, he supported restoring the cache-lookup-error coverage and suggested considering a separate test because direct catalog deletion was artificial.
Improve objectNamesToOids() comment
27 Aug 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1REL_18_STABLE18rc1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #91 of 1 reviewer saw the final version

The diff exactly matches the first patch of #9, adding the 14-line objectNamesToOids() comment in src/backend/catalog/aclchk.c; the accompanying test patch landed separately.

  • Heikki Linnakangassaw the final versiontrailerIn #12, he explicitly endorsed the comment patch from #9, which landed without diff changes.

Nov 2024

2 commits
Proper object locking for GRANT/REVOKE
15 Nov 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #11 of 1 reviewer saw the final version

Compared with #1, the committed aclchk.c passes NULL for the default branch's relation output and removes its local Relation variable and assertion, using the preceding assertion cleanup; the other differences are blank lines, and the isolation-test change is identical.

  • Bertrand Drouvotsaw the final versiontrailerIn #2, he reviewed the refactoring and domain check, manually investigated the changed isolation-test error, and prompted the assertion cleanup supplied in #4.
Add an assertion in get_object_address()
15 Nov 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Peter proposed centralizing the assertion in #3, and Bertrand supplied a .txt attachment in #4 that is not an indexed patchset. The commit credits Bertrand and updates get_object_address() plus callers in alter.c; Peter confirmed applying it in #5.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Credits across 4 commits

Author
Bertrand Drouvot1
Peter EisentrautLLM1
Reviewer
Peter Eisentrautcommitter3
Heikki Linnakangas2
Bertrand Drouvot1
Co author
Noah Misch2
Committer
Peter Eisentraut4

N LLM means N of the credits come from LLM analysis, not from commit trailers.