Sep 2025

1 commit
Remove PointerIsValid()
24 Sep 2025Peter Eisentrautmaster19beta1REL_19_STABLE19beta1Also in: Remove PointerIsValid() (landed as posted)Also in: Consistently use macro HeapTupleIsValid to check the validity of tuples in tablecmds.c (not this thread)

Nov - Dec 2024

3 commits
Define __EXTENSIONS__ on Solaris, too.
4 Dec 2024Tom Lanemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

This follow-up adds -D__EXTENSIONS__ to configure.ac, configure, and meson.build after the POSIX feature selection broke perl.h on hake. Tom Lane reports the failure and successful correction in #17; no attached patchset contains this change.

Define _POSIX_C_SOURCE as 200112L on Solaris.
3 Dec 2024Tom Lanemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

The commit adds -D_POSIX_C_SOURCE=200112L for Solaris in configure.ac, configure, and meson.build, implementing Tom Lane's inline proposal in #10 and build-system placement discussed in #11 and #12. Tom confirms the push in #16.

  • Thomas Munrosaw the final versionLLM analysis, 96% sureThomas identified illumos's selection of the obsolete shmdt declaration and advocated using the standard interface, leading to the feature-macro fix #9.
  • Andres Freundsaw the final versionLLM analysis, 99% sureAndres identified the matching Solaris Meson configuration in #11 and explicitly endorsed the proposed change in #13.
Remove useless casts to (void *)
28 Nov 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surelanded as postedfrom patchset #13 of 3 reviewers saw the final version

The commit matches #1 modulo rebasing: rewriteHandler.c uses the newer walker contexts, and the omitted localbuf.c and ShmemBase cast removals were already present in the commit's parent. The remaining cast-removal changes match, and Peter confirms committing in #7.

  • Tom Lanesaw the final versionLLM analysis, 91% sureTom examined the patch and raised compiler-compatibility and backpatching concerns in #2, which Peter addressed through historical investigation in #4.
  • Bruce Momjiansaw the final versionLLM analysis, 97% sureBruce supported the patch's simplification in #3 and reaffirmed that removing the casts outweighed backpatching complications in #5.
  • Andreas Karlssonsaw the final versionLLM analysis, 95% sureAndreas endorsed removing the casts because they could hide real problems in #6, before the commit.

Credits across 4 commits

Author
Peter EisentrautLLM2
Reviewer
Jacob Champion1
Committer
Peter Eisentraut2
Tom Lane2

N LLM means N of the credits come from LLM analysis, not from commit trailers.