Dec 2024 - Jan 2025

14 commits
Return yyparse() result not via global variable
24 Jan 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #24

Applying all four patches from #24 to the commit parent produces exactly the committed files, including the combined src/backend/nls.mk changes.

Remove flex version checks
17 Jan 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The attachment in #21 raises the minimum to Flex 2.5.37; this commit instead removes version enforcement and simplifies configure discovery, implementing Tom Lane's alternative in #22.

  • Tom Lanesaw the final versionLLM analysis, 100% sureIn #22, he reviewed the version-policy proposal in #21 and recommended removing the check, which became the committed approach.
Drop warning-free support for Flex 2.5.35
15 Jan 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #211 of 1 reviewer saw the final version

Exactly matches the warning-workaround removal portion of #21, including deletion of src/tools/fix-old-flex-code.pl; the accompanying minimum-version patch is excluded.

  • Tom Lanesaw the final versiontrailerHe proposed removing the obsolete declarations in #13 and reviewed the resulting Flex policy proposal in #22.
plpgsql: pure parser and reentrant scanner
8 Jan 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #180 of 1 reviewer saw the final version

Combines the three PL/pgSQL patches from #18, excluding the separate extra-type modernization. Beyond rebasing, src/pl/plpgsql/src/pl_gram.y passes yyscanner through parse_datatype(), initializes the error callback's scanner and suppresses a yynerrs warning.

  • Heikki Linnakangassaw an earlier versiontrailerHe approved the updated PL/pgSQL work in #19, but the committed version subsequently corrected scanner propagation through datatype error handling.
flex code modernization: Replace YY_EXTRA_TYPE define with flex option
6 Jan 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #181 of 1 reviewer saw the final version

Exactly matches the extra-type modernization patch across six scanner files in #18; the three PL/pgSQL patches were committed separately.

  • Heikki Linnakangassaw the final versiontrailerIn #19, he approved the modernization and verified that the syntax predates PostgreSQL's required Flex version.
guc: reentrant scanner
25 Dec 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #102 of 2 reviewers saw the final version

Extracts the GUC scanner patch from #10; src/backend/utils/misc/guc-file.l differs only in whitespace around the yyg declaration and comment.

  • Heikki Linnakangassaw the final versiontrailerHe approved #2 in #3, and its GUC implementation remained unchanged apart from whitespace.
  • Andreas Karlssonsaw the final versiontrailerAfter reviewing the initial expanded series in #4, he explicitly rechecked and approved #10 in #17.
jsonpath scanner: reentrant scanner
24 Dec 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #102 of 2 reviewers saw the final version

The jsonpath implementation exactly matches its portion of #10; the commit additionally changes jsonpath_yyerror's gettext argument index in src/backend/nls.mk.

  • Heikki Linnakangassaw the final versiontrailerHis approval in #3 covers the jsonpath conversion, whose later changes were patch consolidation, typedef guards and gettext metadata.
  • Andreas Karlssonsaw the final versiontrailerHe reviewed the expanded series in #4 and approved the revised remainder in #17.
syncrep parser: pure parser and reentrant scanner
24 Dec 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #101 of 2 reviewers saw the final version

Combines the four syncrep patches from #10, with an exact match in their changed files. The additional src/backend/nls.mk edit updates the syncrep_yyerror gettext argument index.

  • Heikki Linnakangassaw an earlier versiontrailerHis approval in #3 preceded the syncrep yyextra lifetime and yyerror argument-order corrections incorporated into #10.
  • Andreas Karlssonsaw the final versiontrailerHe identified the yyextra lifetime problem in #4 and rechecked the corrected series in #17.
replication parser: pure parser and reentrant scanner
24 Dec 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #102 of 3 reviewers saw the final version

Combines the four replication patches from #10, including Andreas Karlsson's co-authored yyextra work originating in #4. Commit edits remove the CHECK1 diagnostic and a FIXME comment and update src/backend/nls.mk.

  • Heikki Linnakangassaw an earlier versiontrailerHis approval in #3 preceded the replication yyextra implementation and argument-order fixes supplied in #4.
  • Andreas Karlssonsaw the final versiontrailerHe supplied replication fixes and yyextra code in #4, then reviewed the integrated version and declared it ready in #17.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
bootstrap: pure parser and reentrant scanner
19 Dec 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #22 of 2 reviewers saw the final version

Combines the two bootstrap patches from #2, adding a guarded yyscan_t declaration in src/include/bootstrap/bootstrap.h consistent with the fix discussed in #5.

  • Heikki Linnakangassaw the final versiontrailerHe approved the expanded series in #3, before the small typedef-guard compatibility adjustment.
  • Andreas Karlssonsaw the final versiontrailerHe reviewed the bootstrap-containing series in #4 and endorsed consistent typedef guards in #7.
Small whitespace improvement
19 Dec 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #41 of 1 reviewer saw the final version

Extracts the single blank-line deletion in src/backend/replication/repl_scanner.l from Andreas Karlsson's whitespace fixup in #4; the other whitespace hunk depended on the pending conversion.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Prevent redeclaration of typedef yyscan_t
19 Dec 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #51 of 1 reviewer saw the final version

Takes the cube and seg header fixes from the six-header delta in #5, adding full #ifndef wrappers as Andreas Karlsson recommended in #7. The remaining headers were handled with their module conversions.

  • Andreas Karlssonsaw the final versionLLM analysis, 100% sureIn #7, he endorsed the typedef fix and recommended using #ifndef consistently, which the commit adopted.
seg: pure parser and reentrant scanner
18 Dec 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #22 of 2 reviewers saw the final version

Combines the three seg patches from #2; the only substantive textual difference after applying them is adding the missing word 'for' in the segparse.h include comment.

  • Heikki Linnakangassaw the final versiontrailerHe approved the series in #3, and the seg portion landed with only a comment correction.
  • Andreas Karlssonsaw the final versiontrailerHe reported reviewing the patches in #4, with no seg-specific objection and only a comment correction before landing.
cube: pure parser and reentrant scanner
18 Dec 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #22 of 2 reviewers saw the final version

Exactly matches the combined three-patch cube portion of #2 across contrib/cube/cube.c, cubedata.h, cubeparse.y and cubescan.l; the other modules landed separately.

  • Heikki Linnakangassaw the final versiontrailerHe approved the series in #3, and the cube implementation landed unchanged.
  • Andreas Karlssonsaw the final versiontrailerHe reviewed the expanded series in #4, and its cube implementation landed unchanged.

Credits across 14 commits

Author
Peter EisentrautLLM11
Andreas Karlsson1
Reviewer
Heikki Linnakangas9
Andreas Karlsson7
Peter Eisentrautcommitter2
Tom Lane1
Co author
Andreas Karlsson1
Committer
Peter Eisentraut14

N LLM means N of the credits come from LLM analysis, not from commit trailers.