model-writtenrun 1604 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- jian he proposed removing unreachable constraint-type checks and improving ALTER DOMAIN diagnostics, including rejecting CHECK NO INHERIT, while raising the question of whether accepted NOT DEFERRABLE and INITIALLY IMMEDIATE clauses should be documented #1.
- Alvaro Herrera explained that composing diagnostics through processCASbits would break translation and recommended complete error messages in the caller #2; jian he responded by moving property validation into AlterDomainAddConstraint() and supplying query text for error positions #3.
- jian he then restricted the grammar to the documented constraint forms, making unsupported attributes syntax errors #4, but Alvaro Herrera objected that the simpler code produced worse user-facing diagnostics #5.
- jian he returned to accepting constraint attributes in the grammar and explicitly checking their bits to report domain-specific errors for deferrability, enforceability, and inheritance, with regression tests; this revision already omitted the separate dead-code cleanup #6.
- Peter Eisentraut committed only the switch-removal portion of #4 as 7407b2d48c, using an assertion for the parser invariant and leaving the grammar and API changes out; his announcement said the diagnostic work needed further study #7.
- Alvaro Herrera later proposed an alternative in another thread, arguing that a broader grammar solution would avoid hard-to-maintain bit manipulation #8.
- After Peter Eisentraut asked which approach to pursue #9, jian he refreshed the direct-check implementation with improved messages and tests, also forwarding the alternative for comparison and arguing that its additional machinery offered little benefit for domain constraints #10.
- Alvaro Herrera accepted the direct-check implementation as reasonable and suggested checking deferrability before processCASbits() #11; the thread ends with the dead-code cleanup landed and the diagnostic changes still awaiting completion.