model-writtenrun 2662 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed general IWYU pragmas and catalog-header export annotations to suppress misleading advice caused by PostgreSQL's include conventions in #1.
- Tom Lane questioned the maintenance burden, objected to splitting rmgrdesc.c includes into separately annotated groups, and pointed out the absence of documentation in #2.
- Peter explained that IWYU would provide optional assistance when moving code or using clangd, rather than require universal warning-free use, and proposed central documentation in #3.
- Tom suggested documenting inclusion conventions centrally and reiterated that annotations should preserve alphabetical include ordering in #4.
- Peter submitted the revised series in #5, dropping the rmgrdesc.c changes and adding src/tools/pginclude/README documentation while leaving broader coding-convention documentation for a separate project.
- The three revised patches from #5 landed unchanged apart from rebase context as 74938d1320, fecc8021e1, and 44512e7c95; Peter announced completion in #6.
- After the commits, Peter Geoghegan reported improved clangd automatic header insertion and raised documenting its configuration, while suggesting more testing first, in #7.
- Peter Eisentraut expressed interest and asked about the configuration in #8; Peter Geoghegan then reported mixed results from continued testing and clarified that clang-format controlled include ordering in #9, leaving all submitted patches committed but further automatic-insertion guidance unresolved.