Apr 2026

1 commit
Use standard C23 and C++ attributes if available
1 Apr 2026Peter Eisentrautmaster19beta1REL_19_STABLE19beta1
LLM analysis, 94% suremodified before commitmoderate changesfrom patchset #120 of 1 reviewer saw the final version

76f4b92bac develops the fourth patch of #12: src/include/c.h gains standard noreturn/nodiscard attributes, extended with C++ detection and maybe_unused support. It also removes obsolete noreturn fallbacks and corrects attribute placement in slab.c, radixtree.h, and worker_spi.c.

  • Andres Freundsaw an earlier versionLLM analysis, 94% sureAndres reviewed the C23 proposal and questioned attribute ordering in #13 and #15, before the later C++ and maybe_unused extensions.

Mar 2025

2 commits
Swap order of extern/static and pg_nodiscard
14 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #122 of 2 reviewers saw the final version

05cbd6cb22 takes the third patch of #12, preserving its declaration-order changes across five headers. The additional src/include/c.h change only updates the explanation of pg_nodiscard's name and placement, as described in #17.

  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerIlmari questioned compiler detection in the original series in #8; the declaration-order component subsequently received only rebase adjustments and comment changes.
  • Andres Freundsaw the final versiontrailerAndres reviewed the final posted series in #13, after which this component received only explanatory comment changes.
pg_noreturn to replace pg_attribute_noreturn()
13 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #120 of 2 reviewers saw the final version

3691edfab9 squashes the first two patches of #12, including json_manifest_parse_failure()'s annotation and pg_unreachable(). Across the same 54 files, the only changed added/removed lines are in src/include/c.h, restoring the GCC/SunPro fallback and documenting placement, consistent with #16.

  • Dagfinn Ilmari Mannsåkersaw an earlier versiontrailerIlmari asked whether __has_attribute(noreturn) should supplement compiler detection in #8, before subsequent changes to the fallback selection.
  • Andres Freundsaw an earlier versiontrailerAndres accepted the approach and requested placement documentation in #13, before Peter restored the compiler fallback at commit time in #16.

Credits across 3 commits

Author
Peter EisentrautLLM3
Reviewer
Andres Freund2
Dagfinn Ilmari Mannsåker2
Committer
Peter Eisentraut3

N LLM means N of the credits come from LLM analysis, not from commit trailers.