model-writtenrun 2475 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Andres Freund started the discussion after MSVC emitted an avoidable missing-return warning, proposing a conditional C11 pg_noreturn macro and identifying that existing annotation placement and function-pointer annotations obstructed a direct replacement #1 #2.
- Peter Eisentraut supported following the standard despite losing function-pointer annotations and noted older MSVC requirements and third-party header conflicts; Andres explored compiler flags and explained why mixing standard and GNU annotations on callbacks could cause incompatible function-pointer errors #3 #4 #5 #6.
- Peter posted four patches using a prefixed pg_noreturn macro with C11, GCC, and MSVC implementations, replacing callback annotations with a checked wrapper where needed, moving pg_nodiscard before declarations, and adding optional C23 attribute syntax #7.
- Dagfinn Ilmari Mannsåker questioned compiler detection, and Peter concluded that an additional attribute probe was unnecessary before deciding the GCC fallback itself appeared redundant; the next revision removed that fallback and resolved intervening conflicts #8 #9 #10 #11.
- After Peter rebased the series, Andres accepted the approach, requested documentation of annotation placement, and suggested putting pg_noreturn first; Peter initially considered its ordering relative to pg_noinline harmless #12 #13 #14 #15.
- Peter committed the noreturn conversion and manifest-wrapper fix together as 3691edfab9, restoring a GCC/SunPro fallback for older or explicitly C99 builds and adding placement documentation; he initially deferred both remaining patches because C23 placement rules remained uncertain #16.
- Peter then committed the declaration-order patch as 05cbd6cb22, adding an updated explanatory comment; at the thread's last message, three of the four patches had landed and standard C23 attribute support remained deferred #17.
- The later candidate 76f4b92bac, committed in April 2026, implements an expanded form of the deferred patch from #12, adding C++ and maybe_unused support, removing obsolete noreturn fallbacks, and correcting additional attribute placements; the supplied thread contains no discussion of that later revision.