Jan 2025

3 commits
Add pg_nodiscard decorations to base64 functions
17 Jan 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

The commit adds pg_nodiscard to both base64 function declarations in src/include/common/base64.h, implementing Peter's proposal in #3. These declarations were not changed by the attached patchset #1.

  • Michael Paquiersaw the final versiontrailerMichael endorsed the pg_nodiscard proposal in #4, which landed without an attached patchset.
  • Ranier Vilelasaw the final versiontrailerRanier endorsed the pg_nodiscard proposal in #5, which landed without an attached patchset.
Fix error handling of pg_b64_decode()
16 Jan 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

The commit fixes SCRAM key decoding in src/interfaces/libpq/fe-connect.c by checking decoding failures and validating the actual decoded length. Peter reported this related fix in #3; the attachment in #1 changes only postgres_fdw encoding.

Check return of pg_b64_encode() for error
16 Jan 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #12 of 2 reviewers saw the final version

The commit retains both encoded_len checks from #1 in contrib/postgres_fdw/connection.c, replacing ereport and its explicit SQLSTATE with elog, capitalizing SCRAM, and adjusting indentation. Peter explicitly described the error-reporting change in #3.

  • Michael Paquiersaw the final versionLLM analysis, 99% sureMichael confirmed that both unchecked encoding calls were inconsistent in #2, before the patch landed with light error-reporting edits.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Credits across 3 commits

Author
Peter EisentrautLLM2
Ranier Vilela1
Reviewer
Michael Paquier1
Peter Eisentrautcommitter1
Ranier Vilela1
Committer
Peter Eisentraut3

N LLM means N of the credits come from LLM analysis, not from commit trailers.