model-writtenrun 2642 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Ranier Vilela reported a Coverity warning about unchecked pg_b64_encode() results and supplied a patch that raises errors when either SCRAM key fails to encode in postgres_fdw #1.
- Michael Paquier confirmed that both calls should check their return values and asked Peter Eisentraut to address the inconsistency #2.
- Peter committed Ranier's patch as ff030ebe25, changing ereport to elog to match other callers, and explained that adjustment in #3.
- Peter also committed a related libpq fix as d278541be4, checking decoding failures and validating actual decoded SCRAM key lengths; he announced this additional fix in #3.
- Peter proposed adding pg_nodiscard to both base64 functions in #3, and Michael and Ranier endorsed the proposal in #4 and #5.
- Peter added the attributes in b0eff10988 and confirmed completion in #6; Ranier's thanks in #7 closed the thread with all proposed code changes landed.