Feb 2025

5 commits
Fix comment for MAX_BACKENDS.
24 Feb 2025Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #171 of 1 reviewer saw the final version

The two-line comment replacement in src/include/storage/procnumber.h exactly matches #17, identifying InitializeMaxBackends() as the checking location.

  • Andres Freundsaw the final versiontrailerAndres endorsed the comment correction in #18 before it was committed.
Move MAX_BACKENDS to procnumber.h
24 Feb 2025Andres Freundmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #121 of 1 reviewer saw the final version

Matches the first patch in #12, including the move to src/include/storage/procnumber.h and include adjustments, except that MAX_BACKENDS uses 1U instead of 1 in its shift expression.

  • Thomas Munrosaw the final versiontrailerThomas endorsed the header placement and bit-count definition in #13, then withdrew his alternative naming and extra-backend suggestion in #15 after the count-versus-index explanation.
Base LWLock limits directly on MAX_BACKENDS
24 Feb 2025Andres Freundmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #121 of 1 reviewer saw the final version

Matches the second patch in #12 modulo diff alignment and whitespace: src/backend/storage/lmgr/lwlock.c derives lock masks from MAX_BACKENDS, relocates flag bits, and checks overlap.

  • Jacob Brazealsaw the final versiontrailerJacob endorsed the draft and identified the redundant assertion and missing exclusive-bit overlap check in #7, #8, and #9; the subsequent changes to this patch were assertion and comment refinements implementing that review.
bufmgr: Make it easier to change number of buffer state bits
24 Feb 2025Andres Freundmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1Also in: AIO writes vs hint bits vs checksums (not this thread)
LLM analysis, 100% surelanded as postedfrom patchset #120 of 1 reviewer saw the final version

The commit exactly matches the third patch in #12, adding named bit counts, derived masks, and size assertions in src/include/storage/buf_internals.h. This February 2025 submission supersedes the November 2024 component in #576179 from thread #50304, whose current verdict agrees that this thread supplied the committed version.

  • Heikki Linnakangasno review foundtrailerAndres reports in #12 that Heikki reviewed the imported patch in another thread, but Heikki has no review activity in this thread.
Add static asserts for MAX_BACKENDS limiting factors
24 Feb 2025Andres Freundmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #121 of 2 reviewers saw the final version

Preserves the buffer-refcount assertion from the fourth patch in #12 and adds assertions and includes in src/backend/storage/lmgr/deadlock.c and src/backend/utils/cache/inval.c. These additional constraints were requested in #13 and confirmed as committed in #16.

  • Thomas Munrosaw the final versionLLM analysis, 98% sureThomas requested assertions for the two remaining documented limits in #13 and explained the signed invalidation field in #15, directly informing the committed additions.
  • Jacob Brazealsaw an earlier versionLLM analysis, 85% sureJacob endorsed the draft series, including its buffer-refcount assertion, in #7, before the assertion patch gained checks in two additional subsystems.

Credits across 5 commits

Author
Andres FreundLLM4
Nathan BossartLLM1
Reviewer
Andres Freund1
Heikki Linnakangas1
Jacob Brazeal1
Thomas Munro1
Reported by
Jacob Brazeal1
Committer
Andres Freund4
Nathan Bossart1

N LLM means N of the credits come from LLM analysis, not from commit trailers.