Feb 2025

11 commits
backend libpq void * argument for binary data
23 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #31 of 1 reviewer saw the final version

Matches the backend libpq patch in #3, including all six files changing binary-data parameters and removing caller casts.

  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerAfter initially skimming #1, he reported thoroughly reading, applying, and building #3 in #4.
SnapBuildRestoreContents() void * argument for binary data
23 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #31 of 1 reviewer saw the final version

Matches the SnapBuildRestoreContents() patch in #3: the declaration, definition, and four callers in src/backend/replication/logical/snapbuild.c have identical edits.

  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerAfter initially skimming #1, he reported thoroughly reading, applying, and building #3 in #4.
jsonb internal API void * argument for binary data
23 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #31 of 1 reviewer saw the final version

Matches the jsonb patch in #3, with identical parameter and caller changes in src/backend/utils/adt/jsonb_util.c.

  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerAfter initially skimming #1, he reported thoroughly reading, applying, and building #3 in #4.
backend launchers void * arguments for binary data
21 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #31 of 1 reviewer saw the final version

Matches all 26 files of the backend-launcher patch in #3, including const void * startup arguments and corresponding declarations.

  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerAfter initially skimming #1, he reported thoroughly reading, applying, and building #3 in #4.
Remove various unnecessary (char *) casts
20 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #31 of 1 reviewer saw the final version

Matches the miscellaneous cast-cleanup patch in #3 across 18 files. The earlier pqcomm.c unconstify workaround is absent from both versions.

  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerHe challenged the unconstify workaround in #2 and subsequently read, applied, and built the revised series as reported in #4.
Remove unnecessary (char *) casts [xlog]
13 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #31 of 1 reviewer saw the final version

Retains the WAL caller cast removals from #3, but drops proposed extra parentheses in heapam.c and nbtinsert.c and removes existing redundant parentheses at three heapam.c sites. These are light style adjustments following #4.

  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerIn #4 he reported reading and building #3 and requested consistent parentheses, which Peter incorporated before committing.
XLogRegisterData, XLogRegisterBufData void * argument for binary data
13 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #31 of 1 reviewer saw the final version

Matches the four-file WAL API patch in #3, changing XLogRegisterData(), XLogRegisterBufData(), and XLogRecData.data to const void *.

  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerAfter initially skimming #1, he reported thoroughly reading, applying, and building #3 in #4.
Remove unnecessary (char *) casts [checksum]
12 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #31 of 1 reviewer saw the final version

Matches the checksum patch in #3, including cast removals and the PageIsVerifiedExtended() parameter correction across three files.

  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerAfter initially skimming #1, he reported thoroughly reading, applying, and building #3 in #4.
Remove unnecessary (char *) casts [mem]
12 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #31 of 1 reviewer saw the final version

Matches all 20 files of the memory-function cast cleanup in #3; added and removed lines are identical.

  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerHe read, applied, and built #3, citing its memcpy cleanup when discussing parenthesis consistency in #4.
Remove unnecessary (char *) casts [string]
12 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #31 of 1 reviewer saw the final version

Matches the six-file string-function cast cleanup in #3, including the GiST documentation example and replication string copies.

  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerAfter initially skimming #1, he reported thoroughly reading, applying, and building #3 in #4.
Make TLS write functions' buffer arguments pointers const
9 Feb 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #21 of 1 reviewer saw the final version

Extends #2 by also making the be_gssapi_write() definition and declaration accept const void *, preserving its five original edits. In #4, Dagfinn confirms Peter caught this omission because his own test build lacked GSSAPI.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Credits across 11 commits

Author
Peter EisentrautLLM10
Dagfinn Ilmari Mannsåker1
Reviewer
Dagfinn Ilmari Mannsåker10
Peter Eisentrautcommitter1
Committer
Peter Eisentraut11

N LLM means N of the credits come from LLM analysis, not from commit trailers.