Mar 2025

4 commits
Add support for not-null constraints on virtual generated columns
28 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #141 of 4 reviewers saw the final version

The commit implements the NOT NULL patch in #14, including ATRewriteTable and SET EXPRESSION validation and its regression cases. Peter describes his edits in #15: renamed helpers and cache fields, simplified ExecConstraints control flow, and reduced assertions; the diff also cleans up tests and comments.

  • Xuneng Zhousaw an earlier versiontrailerIn #2, Xuneng questioned the separate expression cache and variable naming in #1, before ALTER TABLE validation and later executor changes.
  • Navneet Kumarsaw an earlier versiontrailerNavneet demonstrated the ALTER TABLE ADD COLUMN failure in #4 and #5, prompting the validation changes in #8.
  • Álvaro Herrerasaw an earlier versiontrailerÁlvaro supplied substantial NOT NULL review fixes in #10 and discussed #11 in #13, before Peter's local executor control-flow changes described in #15.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Modernize some code a bit
28 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 97% surepart of a posted patchsetlight changesfrom patchset #141 of 3 reviewers saw the final version

This extracts the ExecConstraints loop-variable, attribute-number, and error-reporting cleanup present in #14, adding analogous ExecRelCheck modernization and palloc0_array usage. The commit credits Peter as author and jian he as co-author.

  • Xuneng Zhousaw an earlier versiontrailerXuneng reviewed cache handling and naming in #2, before the executor refactoring and cleanup incorporated into #14.
  • Navneet Kumarsaw an earlier versiontrailerNavneet tested the earlier NOT NULL implementation in #4 and #5, before the subsequent executor review changes.
  • Álvaro Herrerasaw the final versiontrailerÁlvaro supplied the narrowed variable scopes and AttrNumber loop cleanup in #10, which #11 incorporated and this commit extracts with further light modernization.
Rename a node field for clarity
28 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 98% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

No attachment renames ri_ConstraintExprs to ri_CheckConstraintExprs; this is Peter's preparatory clarification in src/backend/executor/execMain.c and src/include/nodes/execnodes.h. It addresses the distinction between expression caches discussed in #2 and #3.

  • Xuneng Zhousaw an earlier versionLLM analysis, 83% sureXuneng questioned the purpose and naming distinction of the constraint-expression caches in #2, motivating clarification, but did not review the final rename or the later series.
Change one loop in ATRewriteTable to use 1-based attnums
21 Mar 2025Álvaro Herreramaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #111 of 1 reviewer saw the final version

The commit matches the separate ATRewriteTable cleanup in #11: store one-based attnums, use foreach_int, and adjust slot, descriptor, and error-reporting accesses. Only surrounding context changes when applied independently of NOT NULL support, as confirmed in #13.

  • Álvaro Herrerasaw the final versioncommittercommitted the patch

Credits across 4 commits

Author
jian he2
Peter EisentrautLLM1
Reviewer
Alvaro Herreracommitter3
Navneet Kumar2
Xuneng Zhou2
Peter Eisentrautcommitter1
Co author
jian he1
Committer
Peter Eisentraut3
Alvaro Herrera1

N LLM means N of the credits come from LLM analysis, not from commit trailers.