model-writtenrun 2392 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- jian he proposed enforcing NOT NULL on virtual generated columns by evaluating cached IS NOT NULL expressions during constraint checks, while leaving their physical storage null #1.
- Xuneng Zhou questioned the separate expression cache and unclear naming #2; jian retained a dedicated cache, clarified its purpose, and consolidated violation reporting in the next revision #3.
- jian also expanded the series to support domain-typed virtual generated columns, with a preparatory executor-function rename and an initial implementation that could require table rewriting when adding constrained domain columns #3.
- Navneet Kumar demonstrated that adding a NOT NULL virtual column to an existing populated table incorrectly failed #4 #5; jian added ATRewriteTable evaluation, SET EXPRESSION validation, and regression coverage to fix it #8.
- The domain work then changed to scan-based validation instead of table rewriting and introduced soft-error expression helpers so ALTER DOMAIN could report the affected table and column #9.
- Álvaro Herrera supplied fix-up patches for error wording, formatting, attribute-list handling, return types, variable scopes, and comments, and raised a question about composite-value null semantics #10.
- jian incorporated Álvaro's fixes, explained the dummy ResultRelInfo, retained scalar null testing for composite values, and proposed a separate cleanup to make both attribute lists use one-based numbering #11.
- Álvaro committed that independent numbering cleanup as 1d617a2028 and left the main feature for Peter Eisentraut #13; jian then rebased the remaining NOT NULL patch and tidied its comments and tests #14.
- Peter prepared the feature by clarifying the existing check-constraint cache name in 9a9ead1105 and extracting executor modernization from #14 into 747ddd38cb.
- Peter committed NOT NULL support from #14 as cdc168ad4b, with naming changes, simplified executor control flow, fewer assertions, and test cleanup, then announced completion #15.
- The thread ends with NOT NULL support landed and jian resubmitting the remaining domain-support series, including executor renaming, soft-error helpers, and domain constraint validation; no landing of those remaining patches is shown #16.