Apr 2025

1 commit
read_stream: Fix overflow hazard with large shared buffers
7 Apr 2025Andres Freundmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Andres reported overflow when forwarded_buffers is added to the int16 buffer_limit and proposed widening the variable #15. The commit implements that discussion-only fix in src/backend/storage/aio/read_stream.c by using int and clamping again after addition; no attached patchset contains it #17 #18.

  • Thomas Munrosaw the final versionLLM analysis, 82% sureThomas discussed widening the integer types and explicitly endorsed Andres's proposed minimal overflow fix before it was committed #16 #17 #18.

Mar 2025

6 commits
Support buffer forwarding in StartReadBuffers().
21 Mar 2025Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #111 of 1 reviewer saw the final version

The final StartReadBuffers() patch in #11 supplies the forwarding implementation and removal of io_buffers_len in src/backend/storage/buffer/bufmgr.c and src/include/storage/bufmgr.h. The commit adds two assertions and rewrites API comments while preserving the operational logic.

  • Andres Freundsaw the final versiontrailerAndres reported testing the original patch stack in #5, and its bufmgr forwarding patch remains unchanged through #11 apart from the light assertion and documentation edits at commit time.
Support buffer forwarding in read_stream.c.
21 Mar 2025Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #110 of 1 reviewer saw the final version

The read_stream.c forwarding patch in #11 supplies incremental queue initialization, forwarded-pin accounting, overflow-copy clearing, and reset cleanup. The commit edits comments, reuses the already-clamped nblocks value, and updates queue-clearing checks to use stream->io_combine_limit.

  • Andres Freundsaw an earlier versionLLM analysis, 93% sureAndres reported testing the original stack in #5 and receives explicit Tested-by credit in ed0b87caac, but forwarding's pin-limit accounting was subsequently moved into the revised I/O-start path #11.
Simplify distance heuristics in read_stream.c.
15 Mar 2025Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #110 of 1 reviewer saw the final version

This implements the distance-heuristic patch from #11, making all I/O increase look-ahead and cache hits reduce it in src/backend/storage/aio/read_stream.c. Besides comment edits and adjustment to the preceding advice commit, it omits the proposed direct-I/O override that set max_ios to zero.

  • Andres Freundsaw an earlier versiontrailerAndres endorsed the revised approach in #10, but the direct-I/O concurrency override present in that version was omitted before commitment.
Improve read_stream.c advice for dense streams.
15 Mar 2025Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1Also in: BitmapHeapScan streaming read user and prelim refactoring (modified before commit)
Respect changing pin limits in read_stream.c.
14 Mar 2025Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #110 of 1 reviewer saw the final version

The commit implements the dynamic pin-limit patch from #11 in src/backend/storage/aio/read_stream.c, with renamed limit APIs and edited comments. Thomas explicitly reports dropping the pending_read_nblocks reset hunk as unrelated to this commit #12.

  • Andres Freundsaw an earlier versiontrailerAndres tested the original pin-limit fixes in #5 and questioned exhaustion and deferred-block handling in #10, before the progress condition was corrected in #11 and the reset hunk was removed.
Improve buffer manager API for backend pin limits.
14 Mar 2025Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #111 of 1 reviewer saw the final version

The first patch in #11 matches the new pin-limit APIs and cached MaxProportionalPins calculation across bufmgr.c, localbuf.c, and bufmgr.h. The commit removes Soft from the API names and copy-edits comments, as Thomas confirms in #12.

  • Andres Freundsaw the final versiontrailerAndres endorsed the API in #8 and requested clarification of zero-valued limits in #10, followed only by documentation and naming changes.

Feb 2025

1 commit
Remove arbitrary cap on read_stream.c buffer queue.
27 Feb 2025Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #1

The queue-capacity patch in #1 replaces the four-block estimate with io_combine_limit and widens the distance temporary in src/backend/storage/aio/read_stream.c. The commit changes Max(max_ios, 1) to max_ios + 1, allowing an additional completed-but-unconsumed I/O's buffers, and expands the explanation.

Credits across 8 commits

Author
Thomas MunroLLM7
Andres FreundLLM1
Reviewer
Andres Freund5
Tested by
Melanie Plageman2
Andres Freund1
Reported by
Andres Freund1
Melanie Plageman1
Tomas Vondra1
Committer
Thomas Munro7
Andres Freund1

N LLM means N of the credits come from LLM analysis, not from commit trailers.