Fix api misuse (src/bin/pg_amcheck/pg_amcheck.c)

On Tue, 18 Feb 2025 at 18:18, Ranier Vilela <ranier.vf@gmail.com> wrote:

Hi.

Similar to commit 5b94e27 [1]
The correct function when freeing memory in the frontend,
using the function PQescapeIdentifier, must be
PQfreemem.

Trivial patch attached.

Thanks, this change looks good to me.

Regards,
Vignesh

On Wed, Feb 26, 2025 at 07:04:25PM +0530, vignesh C wrote:

On Tue, 18 Feb 2025 at 18:18, Ranier Vilela <ranier.vf@gmail.com> wrote:

Similar to commit 5b94e27 [1]
The correct function when freeing memory in the frontend,
using the function PQescapeIdentifier, must be
PQfreemem.

Trivial patch attached.

Thanks, this change looks good to me.

There's no point in leaving that unfixed in pg_amcheck, so done down
to 14 with 48e4ae9a0707.
--
Michael

Em qui., 27 de fev. de 2025 às 02:08, Michael Paquier <michael@paquier.xyz>
escreveu:

On Wed, Feb 26, 2025 at 07:04:25PM +0530, vignesh C wrote:

On Tue, 18 Feb 2025 at 18:18, Ranier Vilela <ranier.vf@gmail.com> wrote:

Similar to commit 5b94e27 [1]
The correct function when freeing memory in the frontend,
using the function PQescapeIdentifier, must be
PQfreemem.

Trivial patch attached.

Thanks, this change looks good to me.

There's no point in leaving that unfixed in pg_amcheck, so done down
to 14 with 48e4ae9a0707.

Thank you Michael.

best regards,
Ranier Vilela