Accidental assignment instead of compare in GetOperatorFromCompareType?
Hi all,
It looks like commit 630f9a43cece93cb4a5c243b30e34abce6a89514 omitted an
equals sign in an ereport() in GetOperatorFromCompareType, giving the line:
cmptype = COMPARE_EQ ? errmsg("could not identify an equality operator for
type %s", format_type_be(opcintype)) :
I think the impact is just that we'd never see the error messages for
the COMPARE_OVERLAP and COMPARE_CONTAINED_BY cases logged.
Regards,
Jacob
Attachments:
v01_fix_typos.patchapplication/octet-stream; name=v01_fix_typos.patchDownload+9-9
Sorry, I attached the wrong patch.
Show quoted text
Attachments:
v1_cmp_assign.patchapplication/octet-stream; name=v1_cmp_assign.patchDownload+1-1
On Sun, Mar 02, 2025 at 09:06:18PM -0800, Jacob Brazeal wrote:
Sorry, I attached the wrong patch.
errcode(ERRCODE_UNDEFINED_OBJECT),
- cmptype = COMPARE_EQ ? errmsg("could not identify an equality operator for type %s", format_type_be(opcintype)) :
+ cmptype == COMPARE_EQ ? errmsg("could not identify an equality operator for type %s", format_type_be(opcintype)) :Yep, you're right. That's a typo coming from the recent commit
630f9a43cece.
--
Michael
On 03.03.25 06:05, Jacob Brazeal wrote:
Hi all,
It looks like commit 630f9a43cece93cb4a5c243b30e34abce6a89514 omitted an
equals sign in an ereport() in GetOperatorFromCompareType, giving the line:cmptype = COMPARE_EQ ? errmsg("could not identify an equality operator
for type %s", format_type_be(opcintype)) :I think the impact is just that we'd never see the error messages for
the COMPARE_OVERLAP and COMPARE_CONTAINED_BY cases logged.
Fixed, thanks.