pgoutput: comment atop rel_sync_cache_publication_cb() has an inconsistency
Dear hackers,
While reading the code, I found $SUBJECT. It says:
```
/*
* Publication relation/schema map syscache invalidation callback
*
* Called for invalidations on pg_publication and pg_namespace.
*/
static void
rel_sync_cache_publication_cb(Datum arg, int cacheid, uint32 hashvalue)
```
But this won't be called for invalidating pg_publication. It should have been
updated by 3abe9dc1, but it was an oversight.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
Attachments:
0001-pgoutput-Update-code-comment.patchapplication/octet-stream; name=0001-pgoutput-Update-code-comment.patchDownload
From 7d0a8da453cfa63490a901f0d2ba4848cc6dd420 Mon Sep 17 00:00:00 2001
From: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Date: Tue, 25 Mar 2025 11:52:32 +0900
Subject: [PATCH] pgoutput: Update code comment
Oversight in 3abe9dc1
---
src/backend/replication/pgoutput/pgoutput.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/replication/pgoutput/pgoutput.c b/src/backend/replication/pgoutput/pgoutput.c
index 8357bf8b4c0..ac34092aaaf 100644
--- a/src/backend/replication/pgoutput/pgoutput.c
+++ b/src/backend/replication/pgoutput/pgoutput.c
@@ -2400,7 +2400,7 @@ rel_sync_cache_relation_cb(Datum arg, Oid relid)
/*
* Publication relation/schema map syscache invalidation callback
*
- * Called for invalidations on pg_publication and pg_namespace.
+ * Called for invalidations on pg_namespace.
*/
static void
rel_sync_cache_publication_cb(Datum arg, int cacheid, uint32 hashvalue)
--
2.43.5
On Tue, Mar 25, 2025 at 8:31 AM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
Dear hackers,
While reading the code, I found $SUBJECT. It says:
```
/*
* Publication relation/schema map syscache invalidation callback
*
* Called for invalidations on pg_publication and pg_namespace.
*/
static void
rel_sync_cache_publication_cb(Datum arg, int cacheid, uint32 hashvalue)
```But this won't be called for invalidating pg_publication. It should have been
updated by 3abe9dc1, but it was an oversight.
Agreed and thanks for the patch.
--
With Regards,
Amit Kapila.