Jul 2025

1 commit
Speed up byteain by not parsing traditional-style input twice.
18 Jul 2025Tom Lanemaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #63 of 3 reviewers saw the final version

The commit takes only Steven Niu's first patch, most recently included in #6, rejecting the second patch's StringInfo implementation and contrib/btree_gin tests as Tom proposed #10. The retained change was adapted to src/backend/utils/adt/bytea.c with cosmetic and variable cleanups plus double-backslash tests in src/test/regress/sql/strings.sql, confirmed in #11.

  • Kirill Reshkesaw the final versiontrailerKirill questioned the performance claim because strlen still scans the input and requested a benchmark #2; the accepted original implementation subsequently received only light changes.
  • Stepan Neretinsaw the final versiontrailerStepan examined Steven's implementation while proposing the StringInfo alternative #4 and benchmarked the revised series #8, while the committed portion retained Steven's approach with light edits.
  • Tom Lanesaw the final versiontrailerTom rejected StringInfo overhead, selected the first patch, requested double-backslash coverage #10, and committed the adjusted implementation with a reported roughly 40% benchmark improvement #11.

Credits across 1 commit

Author
Steven Niu1
Reviewer
Kirill Reshke1
Stepan Neretin1
Tom Lane1
Committer
Tom Lane1