Apr 2025

2 commits
Add missing PGDLLIMPORT markings
11 Apr 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #15 of 5 reviewers saw the final version

The diff exactly matches #1 after excluding src/include/utils/memutils.h: seven declarations across five headers remain. The excluded marking had already landed with the rename in 55ef7abf88, and Peter confirmed committing the remainder in #10.

  • Daniel Gustafssonsaw the final versionLLM analysis, 100% sureDaniel explicitly approved the pg_be_oauth_mech import marking in #2.
  • Jacob Championsaw the final versionLLM analysis, 98% sureJacob gave an explicit LGTM in #3.
  • Andres Freundsaw the final versionLLM analysis, 99% sureAndres examined whether the AIO callback declarations should be exported in #4 and accepted marking them under the existing policy in #6.
  • Robert Haassaw the final versionLLM analysis, 90% sureRobert defended retaining the proposed markings because extensions may need symbols core developers consider internal #5 #7.
  • Tom Lanesaw the final versionLLM analysis, 90% sureTom supported the export-everything policy underlying the patch and rejected speculative optimization benefits as grounds for omitting markings #8.
Rename global variable backing DSA area
10 Apr 2025Daniel Gustafssonmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1Also in: pgsql: Add function to get memory context stats for processes (not this thread)
LLM analysis, 100% surelanded as postedfrom patchset #2

The complete three-file diff exactly matches #2, including MemoryStatsDsaArea and the relocated PGDLLIMPORT declaration in src/include/utils/memutils.h. The supplied verdict for thread #51392 confirms that its later patch #589167 independently used shm_area and omitted the declaration changes, so it was not the committed source.

Credits across 2 commits

Author
Daniel Gustafsson1
Peter EisentrautLLM1
Reported by
Laurenz Albe1
Peter Eisentraut1
Committer
Daniel Gustafsson1
Peter Eisentraut1

N LLM means N of the credits come from LLM analysis, not from commit trailers.