model-writtenrun 2308 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- David Rowley proposed replacing unnecessary formatted appends with appendPQExpBufferStr or appendPQExpBufferChar in #1, including cases dating back to v11, and supplied diagnostic instrumentation explicitly excluded from commitment.
- In #1, David favored fixing all identified cases immediately rather than only new-to-v18 cases or doing nothing, so future annual cleanups would not need to ignore older inconsistencies.
- David first committed the unchanged new-to-v18 subset as 3fae25cbb3, then posted the older-code remainder in #2 and again advocated committing it to master.
- Daniel Gustafsson supported committing the remainder in #3.
- David committed the remainder unchanged as 1bd08f6ba5 and confirmed completion in #4; all proposed call-site fixes had landed, while the diagnostic instrumentation remained intentionally uncommitted.