Typos in the comment for the estimate_multivariate_ndistinct()

Started by Tender Wangabout 1 year ago4 messageshackers
Jump to latest
#1Tender Wang
tndrwang@gmail.com

Hi,

While reading the estimate_multivariate_ndistinct(),
I think "If a match it found, *varinfos is
* updated to remove the list of matched varinfos"
should be "If a match is found, *varinfos is
* updated to remove the list of matched varinfos"
I've attached a patch for that.

--
Thanks,
Tender Wang

Attachments:

0001-Fix-a-typo.patchtext/plain; charset=US-ASCII; name=0001-Fix-a-typo.patchDownload+1-2
#2Tender Wang
tndrwang@gmail.com
In reply to: Tender Wang (#1)
Re: Typos in the comment for the estimate_multivariate_ndistinct()

Tender Wang <tndrwang@gmail.com> 于2025年4月14日周一 21:34写道:

Hi,

While reading the estimate_multivariate_ndistinct(),
I think "If a match it found, *varinfos is
* updated to remove the list of matched varinfos"
should be "If a match is found, *varinfos is
* updated to remove the list of matched varinfos"
I've attached a patch for that.

Hi Alvaro,

Can you help me double-check this?

--
Thanks,
Tender Wang

#3Daniel Gustafsson
daniel@yesql.se
In reply to: Tender Wang (#1)
Re: Typos in the comment for the estimate_multivariate_ndistinct()

On 14 Apr 2025, at 15:34, Tender Wang <tndrwang@gmail.com> wrote:

Hi,

While reading the estimate_multivariate_ndistinct(),
I think "If a match it found, *varinfos is
* updated to remove the list of matched varinfos"
should be "If a match is found, *varinfos is
* updated to remove the list of matched varinfos"
I've attached a patch for that.

Seems like a correct change.

--
Daniel Gustafsson

#4Tender Wang
tndrwang@gmail.com
In reply to: Daniel Gustafsson (#3)
Re: Typos in the comment for the estimate_multivariate_ndistinct()

Daniel Gustafsson <daniel@yesql.se> 于2025年4月16日周三 22:20写道:

On 14 Apr 2025, at 15:34, Tender Wang <tndrwang@gmail.com> wrote:

Hi,

While reading the estimate_multivariate_ndistinct(),
I think "If a match it found, *varinfos is
* updated to remove the list of matched varinfos"
should be "If a match is found, *varinfos is
* updated to remove the list of matched varinfos"
I've attached a patch for that.

Seems like a correct change.

Thanks for checking.

--
Thanks,
Tender Wang