Typos in the comment for the estimate_multivariate_ndistinct()
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t51446psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 27, 2026 at 09:34 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t51446_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t51446_1 && git checkout t51446_1Patchset v1 (message #1) is on t51446_1
Hi,
While reading the estimate_multivariate_ndistinct(),
I think "If a match it found, *varinfos is
* updated to remove the list of matched varinfos"
should be "If a match is found, *varinfos is
* updated to remove the list of matched varinfos"
I've attached a patch for that.
--
Thanks,
Tender Wang
Tender Wang <tndrwang@gmail.com> 于2025年4月14日周一 21:34写道：
Hi,
While reading the estimate_multivariate_ndistinct(),
I think "If a match it found, *varinfos is
* updated to remove the list of matched varinfos"
should be "If a match is found, *varinfos is
* updated to remove the list of matched varinfos"
I've attached a patch for that.
Hi Alvaro,
Can you help me double-check this?
--
Thanks,
Tender Wang
On 14 Apr 2025, at 15:34, Tender Wang <tndrwang@gmail.com> wrote:
Hi,
While reading the estimate_multivariate_ndistinct(),
I think "If a match it found, *varinfos is
* updated to remove the list of matched varinfos"
should be "If a match is found, *varinfos is
* updated to remove the list of matched varinfos"
I've attached a patch for that.
Seems like a correct change.
--
Daniel Gustafsson
Daniel Gustafsson <daniel@yesql.se> 于2025年4月16日周三 22:20写道：
On 14 Apr 2025, at 15:34, Tender Wang <tndrwang@gmail.com> wrote:
Hi,
While reading the estimate_multivariate_ndistinct(),
I think "If a match it found, *varinfos is
* updated to remove the list of matched varinfos"
should be "If a match is found, *varinfos is
* updated to remove the list of matched varinfos"
I've attached a patch for that.Seems like a correct change.
Thanks for checking.
--
Thanks,
Tender Wang