minor error message enhancement in refuseDupeIndexAttach

Started by jian heabout 1 year ago3 messageshackers
Jump to latest
#1jian he
jian.universality@gmail.com

hi.

minor error message enhancement

in refuseDupeIndexAttach, we can change from

errdetail("Another index is already attached for partition \"%s\"."...)

to

errdetail("Another index \"%s\" is already attached for partition \"%s\".")

So we can easily understand which index is already attached for
partition \"%s\".

Attachments:

v1-0001-minor-error-message-enhancement.patchtext/x-patch; charset=US-ASCII; name=v1-0001-minor-error-message-enhancement.patchDownload+3-3
#2Daniel Gustafsson
daniel@yesql.se
In reply to: jian he (#1)
Re: minor error message enhancement in refuseDupeIndexAttach

On 15 Apr 2025, at 10:52, jian he <jian.universality@gmail.com> wrote:

in refuseDupeIndexAttach, we can change from

errdetail("Another index is already attached for partition \"%s\"."...)

to

errdetail("Another index \"%s\" is already attached for partition \"%s\".")

So we can easily understand which index is already attached for
partition \"%s\".

That seems like it could be handy. As this relates to chaning old and existing
behavior, and we are in feature freeze, I suggest registering this in the
commitfest app.

--
Daniel Gustafsson

#3Peter Eisentraut
peter_e@gmx.net
In reply to: Daniel Gustafsson (#2)
Re: minor error message enhancement in refuseDupeIndexAttach

On 15.04.25 11:02, Daniel Gustafsson wrote:

On 15 Apr 2025, at 10:52, jian he <jian.universality@gmail.com> wrote:

in refuseDupeIndexAttach, we can change from

errdetail("Another index is already attached for partition \"%s\"."...)

to

errdetail("Another index \"%s\" is already attached for partition \"%s\".")

So we can easily understand which index is already attached for
partition \"%s\".

That seems like it could be handy. As this relates to chaning old and existing
behavior, and we are in feature freeze, I suggest registering this in the
commitfest app.

committed