Apr 2025

1 commit
pg_dump: Set private_date pointer to NULL in callback
17 Apr 2025Daniel Gustafssonmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #14 of 4 reviewers saw the final version

The single code hunk in b669293e34 exactly matches #1, adding cs->private_data = NULL in EndCompressorZstd() in src/bin/pg_dump/compress_zstd.c. The commit description clarifies that this improves code hygiene without fixing a currently observable bug.

  • Daniel Gustafssonsaw the final versiontrailerDaniel endorsed clearing the pointer after the callback in #3 and, as committer, confirmed pushing the unchanged fix in #6.
  • Ashutosh Bapatsaw the final versiontrailerAshutosh examined the caller and gzip implementation, explaining why the existing code is safe while supporting the cleanup in #2.
  • Michael Paquiersaw the final versiontrailerMichael supported the change and said he had been looking at applying the submitted patch in #4.
  • Tom Lanesaw the final versiontrailerTom explained why other compressor methods clear their pointers and challenged the exact analogy while raising no substantial objection to the change in #5.

Credits across 1 commit

Author
Alexander Kuznetsov1
Reviewer
Ashutosh Bapat1
Daniel Gustafsson1
Michael Paquier1
Tom Lane1
Committer
Daniel Gustafsson1