Typo in multixact.c and jsonfuncs.c documentation

Started by Junwang Zhao9 months ago4 messages
#1Junwang Zhao
zhjwpku@gmail.com
1 attachment(s)

Found a trivial typo in multixact.c, after searching the code base
there is another such typo in jsonfuncs.c.

- * range, that is, greater to or equal than oldestMultiXactId, and less than
+ * range, that is, greater than or equal to oldestMultiXactId, and less than

--
Regards
Junwang Zhao

Attachments:

v1-0001-Fix-typo-in-multixact.c-and-jsonfuncs.c-documenta.patchapplication/octet-stream; name=v1-0001-Fix-typo-in-multixact.c-and-jsonfuncs.c-documenta.patchDownload
From e72ac5299bdcfadcfcde20c27e2d86c97b73e638 Mon Sep 17 00:00:00 2001
From: Junwang Zhao <zhjwpku@gmail.com>
Date: Wed, 30 Apr 2025 01:20:17 +0000
Subject: [PATCH v1] Fix typo in multixact.c and jsonfuncs.c documentation

---
 src/backend/access/transam/multixact.c | 2 +-
 src/backend/utils/adt/jsonfuncs.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/backend/access/transam/multixact.c b/src/backend/access/transam/multixact.c
index 9d25a7df0d3..ef91e70f41d 100644
--- a/src/backend/access/transam/multixact.c
+++ b/src/backend/access/transam/multixact.c
@@ -1287,7 +1287,7 @@ GetNewMultiXactId(int nmembers, MultiXactOffset *offset)
  * range, in which case an error would be raised.
  *
  * In all other cases, the passed multixact must be within the known valid
- * range, that is, greater to or equal than oldestMultiXactId, and less than
+ * range, that is, greater than or equal to oldestMultiXactId, and less than
  * nextMXact.  Otherwise, an error is raised.
  *
  * isLockOnly must be set to true if caller is certain that the given multi
diff --git a/src/backend/utils/adt/jsonfuncs.c b/src/backend/utils/adt/jsonfuncs.c
index 9f43b58dba5..eab102a2474 100644
--- a/src/backend/utils/adt/jsonfuncs.c
+++ b/src/backend/utils/adt/jsonfuncs.c
@@ -1723,7 +1723,7 @@ push_path(JsonbParseState **st, int level, Datum *path_elems,
 {
 	/*
 	 * tpath contains expected type of an empty jsonb created at each level
-	 * higher or equal than the current one, either jbvObject or jbvArray.
+	 * higher or equal to the current one, either jbvObject or jbvArray.
 	 * Since it contains only information about path slice from level to the
 	 * end, the access index must be normalized by level.
 	 */
-- 
2.39.5

#2David Rowley
dgrowleyml@gmail.com
In reply to: Junwang Zhao (#1)
Re: Typo in multixact.c and jsonfuncs.c documentation

On Wed, 30 Apr 2025 at 13:25, Junwang Zhao <zhjwpku@gmail.com> wrote:

Found a trivial typo in multixact.c, after searching the code base
there is another such typo in jsonfuncs.c.

Thanks. Pushed.

David

#3Fujii Masao
masao.fujii@oss.nttdata.com
In reply to: David Rowley (#2)
Re: Typo in multixact.c and jsonfuncs.c documentation

On 2025/04/30 10:41, David Rowley wrote:

On Wed, 30 Apr 2025 at 13:25, Junwang Zhao <zhjwpku@gmail.com> wrote:

Found a trivial typo in multixact.c, after searching the code base
there is another such typo in jsonfuncs.c.

Thanks. Pushed.

This commit seems to have caused an indent-check failure on the buildfarm member koel.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&amp;dt=2025-04-30%2002%3A19%3A00

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

#4David Rowley
dgrowleyml@gmail.com
In reply to: Fujii Masao (#3)
Re: Typo in multixact.c and jsonfuncs.c documentation

On Wed, 30 Apr 2025 at 19:13, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:

This commit seems to have caused an indent-check failure on the buildfarm member koel.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&amp;dt=2025-04-30%2002%3A19%3A00

Thanks. Fixed.

David