Jun 2025

2 commits
Restrict virtual columns to use built-in functions and types
25 Jun 2025Peter Eisentrautmaster18beta2REL_19_STABLE18beta2REL_18_STABLE18beta2
LLM analysis, 100% suremodified before commitlight changesfrom patchset #421 of 1 reviewer saw the final version

The commit combines both patches from #42; all added and removed lines in heap.c and the regression files match the combined submission. The remaining changes clarify the column-type restriction in both documentation files and the commit message, and bump src/include/catalog/catversion.h.

  • jian hesaw the final versiontrailerjian he explained the immutability safeguard in #33, found missing type coverage and supplied a fix in #40 and #41, then reviewed the final series and identified the separate ALTER TABLE defect in #43.
Fix virtual generated column type checking for ALTER TABLE
24 Jun 2025Peter Eisentrautmaster18beta2REL_19_STABLE18beta2REL_18_STABLE18beta2
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

No attached patchset contains this change: #43 reports the ALTER TABLE omission and supplies an inline ATExecAddColumn() correction. The commit passes CHKATYPE_IS_VIRTUAL in both ATExecAddColumn() and ATPrepAlterColumnType(), adds domain regression tests, and is confirmed as a separate fix in #44.

  • jian hesaw the final versionLLM analysis, 99% sureBefore the commit, jian he demonstrated the missing ALTER TABLE check and proposed the inline flag propagation adopted by the fix in #43.

Credits across 2 commits

Author
Peter EisentrautLLM1
Reviewer
jian he1
Reported by
Feike Steenbergen1
jian he1
Committer
Peter Eisentraut2

N LLM means N of the credits come from LLM analysis, not from commit trailers.