fix notes about password encryption in pg_authid docs

Started by Nathan Bossart11 months ago6 messageshackers
Jump to latest
#1Nathan Bossart
nathandbossart@gmail.com

I noticed that the docs for the pg_authid catalog still indicate that
passwords might be stored "unencrypted," which hasn't been possible since
commit eb61136. The attached patch attempts to fix that. If acceptable,
I'd back-patch it to all supported versions.

--
nathan

#2Nathan Bossart
nathandbossart@gmail.com
In reply to: Nathan Bossart (#1)
Re: fix notes about password encryption in pg_authid docs

On Mon, Jun 02, 2025 at 09:16:10AM -0500, Nathan Bossart wrote:

I noticed that the docs for the pg_authid catalog still indicate that
passwords might be stored "unencrypted," which hasn't been possible since
commit eb61136. The attached patch attempts to fix that. If acceptable,
I'd back-patch it to all supported versions.

And now with a patch actually attached...

--
nathan

Attachments:

v1-0001-doc-Fix-notes-about-password-encryption-in-pg_aut.patchtext/plain; charset=us-asciiDownload+1-7
#3Michael Paquier
michael@paquier.xyz
In reply to: Nathan Bossart (#2)
Re: fix notes about password encryption in pg_authid docs

On Mon, Jun 02, 2025 at 09:21:39AM -0500, Nathan Bossart wrote:

On Mon, Jun 02, 2025 at 09:16:10AM -0500, Nathan Bossart wrote:

I noticed that the docs for the pg_authid catalog still indicate that
passwords might be stored "unencrypted," which hasn't been possible since
commit eb61136. The attached patch attempts to fix that. If acceptable,
I'd back-patch it to all supported versions.

Good point.

You are missing one reference in doc/src/sgml/system-views.sgml for
pg_shadow.passwd, no?
--
Michael

#4Nathan Bossart
nathandbossart@gmail.com
In reply to: Michael Paquier (#3)
Re: fix notes about password encryption in pg_authid docs

On Tue, Jun 03, 2025 at 01:43:15PM +0900, Michael Paquier wrote:

You are missing one reference in doc/src/sgml/system-views.sgml for
pg_shadow.passwd, no?

Yup. Here is an updated patch.

--
nathan

Attachments:

v2-0001-doc-Fix-notes-about-password-encryption-in-pg_aut.patchtext/plain; charset=us-asciiDownload+2-8
#5Michael Paquier
michael@paquier.xyz
In reply to: Nathan Bossart (#4)
Re: fix notes about password encryption in pg_authid docs

On Tue, Jun 03, 2025 at 01:01:58PM -0500, Nathan Bossart wrote:

Yup. Here is an updated patch.

Looks fine to me.
--
Michael

#6Nathan Bossart
nathandbossart@gmail.com
In reply to: Michael Paquier (#5)
Re: fix notes about password encryption in pg_authid docs

On Wed, Jun 04, 2025 at 02:11:55PM +0900, Michael Paquier wrote:

Looks fine to me.

Committed, thanks.

--
nathan