model-writtenrun 6997 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Dagfinn Ilmari Mannsåker proposed restricting session RESET completion to variables actually set, plus ALL, ROLE and SESSION; his initial series also fixed role RESET prefix handling, added column RESET and foreign-table SET SCHEMA completion, and removed a generic-completion guard #1.
- Peter Eisentraut objected that session-dependent filtering could confuse users #3; Ilmari defended consistency with database and role RESET completion and explained that fresh sessions would still offer keywords #4, leaving the behavioral disagreement unresolved.
- Ilmari added a schema-qualification fix for the database RESET query and identified it and the role RESET fix as PostgreSQL 18 bugfixes, while deferring the remaining enhancements to PostgreSQL 19 #5.
- The two bugfixes moved to thread #51939, whose later patchset #596794 supplied Tomas Vondra's commits: the unchanged schema qualification dbf5a83d46 and the role RESET fix with a lightly simplified generic-completion exclusion ca09ef3a6a, both backpatched to PostgreSQL 18.
- After those landings, Ilmari submitted three remaining patches, folding guard removal into the session RESET change and replacing its suffix match with an exact match #6.
- Shinya Kato identified a redundant session-query filter and suggested SET WITHOUT OIDS completion #7; Kirill Reshke pointed out the removal of OID support #8, and Ilmari removed the redundant filter while declining completion for the surviving compatibility no-op #9.
- Ilmari expanded the series to restrict ALTER SYSTEM RESET suggestions using postgresql.auto.conf sourcefile information and to offer non-superusers parameters covered by their ALTER SYSTEM grants #10.
- Shinya questioned compatibility with servers predating pg_parameter_acl and reported missing SET LOCAL and SET SESSION parameter completion #13; Kirill confirmed the SESSION gap, noted that SET omitted LOCAL, and recommended separate work #14.
- After a three-month gap, Ilmari supplied a revised series that gates parameter ACL queries on PostgreSQL 15 or newer, simplifies sourcefile matching while accepting rare false positives, and removes invalid SET keywords #15.
- At the thread's end, the two bugfixes had landed through thread #51939 but five enhancement patches remained pending; Ilmari deferred SET LOCAL work because value completion needed additional generator support and opposed adding parameter suggestions after SET SESSION because they would obscure its special forms #15.